Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assign_advice copy instead of return reference #3

Open
jonathanpwang opened this issue Jan 4, 2023 · 0 comments
Open

assign_advice copy instead of return reference #3

jonathanpwang opened this issue Jan 4, 2023 · 0 comments

Comments

@jonathanpwang
Copy link
Collaborator

For direct comparison, this branch https://github.com/axiom-crypto/halo2/tree/axiom/advice-without-lifetimes does assign_advice where the value is copied and returned, versus in branch axiom/faster-witness-generation where only a reference of the value is returned.

halo2-ecc bench msm takes ~650ms witness generation in the former (without lifetimes), while times are more like ~550ms in the latter.

This change is a sub-change of #2 so it explains a portion of the time difference there.
shuklaayush pushed a commit to shuklaayush/halo2 that referenced this issue Apr 10, 2023
@kilic
Add From<bool> traitbound to FieldExt. Should close axiom-crypto#3
af85374
shuklaayush pushed a commit to shuklaayush/halo2 that referenced this issue Apr 10, 2023
@kilic
Merge pull request axiom-crypto#8 from appliedzkp/from_bool
3721879 
Add From<bool> traitbound to FieldExt. Should clone axiom-crypto#3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonathanpwang