protocols/snap/sync_test: each peer have a different account trie #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huyngopt1994
approved these changes
Nov 9, 2024
huyngopt1994
merged commit b447aaf
into
axieinfinity:path-base-implementing
1 check passed
huyngopt1994
pushed a commit
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: ethereum/go-ethereum#25532
Before PBSS, in the snap sync tests, there are no changes to the account trie, so it is acceptable for the peers to use the same account trie. However, PBSS added a tracer that also traces the accessed nodes, leading to the race condition.
This PR is to assign each peer with a copy of the account trie.