Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trie, trie_prefetcher: don't copy when we are the exclusive owner of the trie #592

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

trie, trie_prefetcher: don't copy when we are the exclusive owner of the trie #592

wants to merge 3 commits into from

Commits on Oct 4, 2024

  1. core: add insert chain benchmark with many storage updates

    @minh-bq
    minh-bq committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ee5e110 View commit details
    Browse the repository at this point in the history

  2. trie: don't copy when we are the exclusive owner of the trie 

    Currently, to make the trie copy perform well, we only copy the trie's node on
write. However, there is no tracking on whether the trie is copied or not, so we
always perform copy-on-write even though we are the only owner of the trie. This
commit adds a shared bool to trie, this is set when trie copy is performed. When
the trie is not shared, it is safe to do all the modification in-place without
the need of creating a new copy.

> go test -test.v -test.run=^$ -test.bench=BenchmarkUpdate

           │    old.txt    │               new.txt                │
           │    sec/op     │    sec/op     vs base                │
UpdateBE-8   1247.0n ± 36%   378.4n ± 34%  -69.66% (p=0.000 n=10)
UpdateLE-8   1675.5n ±  1%   430.8n ± 31%  -74.29% (p=0.000 n=10)
geomean       1.445µ         403.7n        -72.07%

           │   old.txt    │              new.txt               │
           │     B/op     │    B/op     vs base                │
UpdateBE-8    1796.0 ± 0%   226.0 ± 0%  -87.42% (p=0.000 n=10)
UpdateLE-8    1848.0 ± 0%   228.5 ± 1%  -87.64% (p=0.000 n=10)
geomean      1.779Ki        227.2       -87.53%

           │  old.txt   │              new.txt               │
           │ allocs/op  │ allocs/op   vs base                │
UpdateBE-8   9.000 ± 0%   4.000 ± 0%  -55.56% (p=0.000 n=10)
UpdateLE-8   9.000 ± 0%   4.000 ± 0%  -55.56% (p=0.000 n=10)
geomean      9.000        4.000       -55.56%
    @minh-bq
    minh-bq committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c988694 View commit details
    Browse the repository at this point in the history

  3. core/state/trie_prefetcher: mark the returned trie as unshared when p… 

    …ossible

Trie's modification is more optimized when it's marked as unshared. When the
prefetched trie is requested, the prefetcher is stopped and the caller can
become the exclusive owner of the trie in most case. When the prefetcher is not
copied (active prefetcher), when possible, the returned trie is marked as
unshared. However, we need to be careful as there might be the case that 2 same
storage trie are prefetched. In that case, don't mark the trie as unshared when
returning to caller.
    @minh-bq
    minh-bq committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8441ee1 View commit details
    Browse the repository at this point in the history