Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consortium-v2/snapshot: make FindAncientHeader more readable #424

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

consortium-v2/snapshot: make FindAncientHeader more readable #424

wants to merge 2 commits into from

Commits on Nov 14, 2024

  1. consortium-v2: add unit test for FindAncientHeader 

    We remove the hash check in FindAncientHeader to make it easier to write unit
test. This is fine because the parents are guaranteed to be ordered and linked
by the check when InsertChain. This is a preparation commit for refactoring this
function.
    @minh-bq
    minh-bq committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    925ef3b View commit details
    Browse the repository at this point in the history

  2. consortium-v2/snapshot: make FindAncientHeader more readable 

    This commit refactors FindAncientHeader, changes its name to findAncestorHeader,
adds some comments and unit test to make the code more readable.
    @minh-bq
    minh-bq committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9e7c9e4 View commit details
    Browse the repository at this point in the history