evm: fix InternalTransactions order (#450)

* evm: add order of internal transactions test

* evm: reorder InternalTransactions

* evm_test: add additional order or internal transactions tests

Add more tests:
- Multiple calls: one contract calls multiple contracts
- Complex calls: one contract calls multiple contracts with various depths
- Delegate calls: one contract delegate-calls multiple contracts

* blockchain: add condition to check when to pass bc.OpEvents() to bc.processor.Process()

Only some blocks need to be tracked with bc.OpEvents(), then just pass bc.OpEvents() to bc.processor.Process() when the flag bc.enableAdditionalChainEvent is on.

---------

Co-authored-by: Bui Quang Minh <[email protected]>

Author: Francesco4203

core/blockchain.go

@@ -1842,7 +1842,11 @@ func (bc *BlockChain) insertChain(chain types.Blocks, verifySeals bool) (int, er
 
 		// Process block using the parent state as reference point
 		substart := time.Now()
-		receipts, logs, internalTxs, usedGas, err := bc.processor.Process(block, statedb, bc.vmConfig, bc.OpEvents()...)
+		publishEvents := []*vm.PublishEvent{}
+		if bc.enableAdditionalChainEvent {
+			publishEvents = bc.OpEvents()
+		}
+		receipts, logs, internalTxs, usedGas, err := bc.processor.Process(block, statedb, bc.vmConfig, publishEvents...)
 		if err != nil {
 			bc.reportBlock(block, receipts, err)
 			atomic.StoreUint32(&followupInterrupt, 1)

core/vm/evm.go

@@ -693,6 +693,15 @@ func (evm *EVM) PublishEvent(
 				err,
 			),
 		)
+		iTrans := *context.InternalTransactions
+		for i := len(iTrans) - 1; i > 0; {
+			if iTrans[i-1].InternalTransactionBody.Order > counter {
+				iTrans[i], iTrans[i-1] = iTrans[i-1], iTrans[i]
+				i--
+			} else {
+				break
+			}
+		}
 	}
 }