From 4abacb213d22e6a8f9cb3a24ed3888015499d1bd Mon Sep 17 00:00:00 2001
From: minh-bq <97180373+minh-bq@users.noreply.github.com>
Date: Mon, 19 Dec 2022 11:18:25 +0700
Subject: [PATCH] fix: remove wrong validatorLimit local variable (#192)

The len(snap.Validators) is not an invariant, it can be changed in the loop when
a new list of validators is loaded. This commit removes that variable and uses
len(snap.Validators)/2 + 1 instead.
---
 consensus/consortium/v2/snapshot.go | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/consensus/consortium/v2/snapshot.go b/consensus/consortium/v2/snapshot.go
index a5d5965954..a1027fd053 100644
--- a/consensus/consortium/v2/snapshot.go
+++ b/consensus/consortium/v2/snapshot.go
@@ -140,11 +140,10 @@ func (s *Snapshot) apply(headers []*types.Header, chain consensus.ChainHeaderRea
 
 	// Number of consecutive blocks out of which a validator may only sign one.
 	// Must be len(snap.Validators)/2 + 1 to enforce majority consensus on a chain
-	validatorLimit := len(snap.Validators)/2 + 1
 	for _, header := range headers {
 		number := header.Number.Uint64()
 		// Delete the oldest validators from the recent list to allow it signing again
-		if limit := uint64(validatorLimit); number >= limit {
+		if limit := uint64(len(snap.Validators)/2 + 1); number >= limit {
 			delete(snap.Recents, number-limit)
 		}
 		// Resolve the authorization key and check against signers
@@ -189,7 +188,7 @@ func (s *Snapshot) apply(headers []*types.Header, chain consensus.ChainHeaderRea
 			for _, val := range newValArr {
 				newVals[val] = struct{}{}
 			}
-			oldLimit := validatorLimit
+			oldLimit := len(snap.Validators)/2 + 1
 			newLimit := len(newVals)/2 + 1
 			if newLimit < oldLimit {
 				for i := 0; i < oldLimit-newLimit; i++ {