fix: not allow set registry to false, update event

Author: nxqbao

contracts/interfaces/IProfile.sol

@@ -31,7 +31,7 @@ interface IProfile {
   /// @dev Event emitted when a address in a profile is changed.
   event ProfileAddressChanged(address indexed id, RoleAccess indexed addressType);
   /// @dev Event emitted when the pubkey of the `id` is changed.
-  event PubkeyChanged(address indexed id);
+  event PubkeyChanged(address indexed id, bytes pubkey);
 
   /// @dev Error of already existed profile.
   error ErrExistentProfile();

contracts/ronin/profile/Profile.sol

@@ -57,11 +57,9 @@ contract Profile is IProfile, ProfileStorage, Initializable {
     if (msg.sender != _profile.admin) revert ErrUnauthorized(msg.sig, RoleAccess.ADMIN);
     _checkDuplicatedPubkey(pubkey);
 
-    _registry[_hashPubkey(_profile.pubkey)] = false;
-
     _profile.pubkey = pubkey;
     _registry[_hashPubkey(pubkey)] = true;
 
-    emit PubkeyChanged(id);
+    emit PubkeyChanged(id, pubkey);
   }
 }

contracts/ronin/profile/ProfileStorage.sol

@@ -8,7 +8,11 @@ import { IProfile } from "../../interfaces/IProfile.sol";
 abstract contract ProfileStorage is IProfile, HasContracts {
   /// @dev Mapping from id address => candidate profile.
   mapping(address => CandidateProfile) internal _id2Profile;
-  /// @dev Mapping from any address or keccak256(pubkey) => whether it is already registered.
+  /**
+   * @dev Mapping from any address or keccak256(pubkey) => whether it is already registered.
+   * This registry can only be toggled to `true` and NOT vice verse. All registered values
+   * cannot be reused.
+   */
   mapping(uint256 => bool) internal _registry;
   /// @dev Upgradeable gap.
   bytes32[49] __gap;

logs/contract_code_sizes.log

@@ -133,7 +133,7 @@
  ············································|···························|·················
  |  PauseEnforcer                            ·                    4.441  ·                │
  ············································|···························|·················
- |  Profile                                  ·                    4.359  ·                │
+ |  Profile                                  ·                    4.357  ·                │
  ············································|···························|·················
  |  Proposal                                 ·                    0.162  ·                │
  ············································|···························|·················