Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate hardhat tests to foundry tests #28

Merged
merged 90 commits into from
Mar 5, 2024

Conversation

huyhuynh3103
Copy link
Collaborator

@huyhuynh3103 huyhuynh3103 commented Feb 4, 2024

Description

  • Remove two local chains since cheating the block number and block timestamp doesn't effect to chain after switching to other chains and switching back.

  • Migrate hardhat tests of BridgeManager contract.

  • Migrate hardhat tests of BridgeTracking contract.

  • Migrate hardhat tests of PauseEnforcer contract.

  • Migrate hardhat tests of MainchainGatewayV3 contract.

  • Migrate hardhat tests of RoninGatewayV3 contract.

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@huyhuynh3103 huyhuynh3103 changed the title test(MainchainGatewayV3 + PauseEnforcer): migrate hardhat tests to foundry tests test: migrate hardhat tests to foundry tests Feb 4, 2024

import "foundry-deployment-kit/BaseMigration.s.sol";

abstract contract BaseMigrationV2 is BaseMigration {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use BaseMigrationExtended instead of V2

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will resolve later

@nxqbao nxqbao changed the base branch from release/v0.1.0 to mainnet March 5, 2024 07:32
@nxqbao nxqbao merged commit 4a3400d into mainnet Mar 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants