Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RNSCommission): fix typo and revert if commission recipient is null #248

Merged
merged 11 commits into from
Jun 25, 2024
Merged

fix(RNSCommission): fix typo and revert if commission recipient is null #248

merged 11 commits into from
Jun 25, 2024

Conversation

TuDo1403
Copy link
Collaborator

Description

This PR fix minor typos and provides check for null recipient when setting new comission info.

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@TuDo1403 TuDo1403 merged commit 62509fb into release/v0.3.5 Jun 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huyhuynh3103 huyhuynh3103 huyhuynh3103 approved these changes

@nxqbao nxqbao nxqbao approved these changes

@ducthotran2010 ducthotran2010 Awaiting requested review from ducthotran2010

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TuDo1403 @nxqbao @huyhuynh3103 @tringuyenskymavis