Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Implement ERC721CommonUpgradeable #10

Merged
merged 21 commits into from
Apr 17, 2024
Merged

Feat: Implement ERC721CommonUpgradeable #10

merged 21 commits into from
Apr 17, 2024

Conversation

huyhuynh3103
Copy link
Contributor

Description

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

@huyhuynh3103 huyhuynh3103 changed the title Feat: Implement ERC721 common upgradable Feat: Implement ERC721CommonUpgradeable Apr 12, 2024
@huyhuynh3103 huyhuynh3103 changed the base branch from main to release/v0.1.0 April 16, 2024 03:03
nxqbao
nxqbao approved these changes Apr 16, 2024
View reviewed changes
Copy link

@nxqbao nxqbao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve the contract. Please move the CI into another PR.

@huyhuynh3103 huyhuynh3103 merged commit 456898d into release/v0.1.0 Apr 17, 2024
1 check failed
@huyhuynh3103 huyhuynh3103 mentioned this pull request Apr 19, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanhtaskymaviscom khanhtaskymaviscom khanhtaskymaviscom approved these changes

@nxqbao nxqbao nxqbao approved these changes

@ducthotran2010 ducthotran2010 Awaiting requested review from ducthotran2010

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huyhuynh3103 @nxqbao @khanhtaskymaviscom