Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readdirplus metric to use histogram instead of counter #1236

Open
dannycjones opened this issue Jan 17, 2025 · 0 comments
Open

Update readdirplus metric to use histogram instead of counter #1236

dannycjones opened this issue Jan 17, 2025 · 0 comments
Labels
good first issue Good for newcomers

Comments

@dannycjones
Copy link
Contributor

Today, the readdirplus.entries metric will simple count all the entries returned in the interval (roughly 5 seconds). However, it would make more sense to return some statistics on how many entries were returned in a readdirplus request when there was more than one in a given interval.

The metric is emitted here:

metrics::counter!("fuse.readdirplus.entries").increment(count as u64);

We should update this code to emit the metric using a histogram instead.

@dannycjones dannycjones added the good first issue Good for newcomers label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant