Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttentiveFP supernode missing #226

Open
alexbui91 opened this issue Oct 11, 2024 · 1 comment
Open

AttentiveFP supernode missing #226

alexbui91 opened this issue Oct 11, 2024 · 1 comment

Comments

@alexbui91
Copy link

alexbui91 commented Oct 11, 2024

Hello, thank you for your work.

I have interest in the AttentiveFP implementation from the paper "Pushing the Boundaries of Molecular Representation for Drug Discovery with the Graph Attention Mechanism". The Google search result leads me to this github repo. According to the paper, after the first phase of GNN message passing, the model adds a super node to the graph and considers this derived version as a new graph. However, according to your implementation, the same graph is used for both two phases. Please correct me if I am wrong.
Screenshot from 2024-10-11 11-18-42

f.y.i: the pytorch geometric implementation seems to be more accurate with the supernode implementation:
https://pytorch-geometric.readthedocs.io/en/latest/_modules/torch_geometric/nn/models/attentive_fp.html#AttentiveFP

Thank you for your consideration!

@mufeili
Copy link
Contributor

mufeili commented Oct 11, 2024

Thank you for the report. Unfortunately, I've left AWS and cannot update the codebase or approve PR from others. You may modify your own fork if you need to use this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants