Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MoleculeCSVDataset to MoleculeDataFrameDataset #190

Open
nbrosse opened this issue Jul 29, 2022 · 2 comments
Open

Rename MoleculeCSVDataset to MoleculeDataFrameDataset #190

nbrosse opened this issue Jul 29, 2022 · 2 comments

Comments

@nbrosse
Copy link

nbrosse commented Jul 29, 2022

MoleculeCSVDataset takes as input a pandas DataFrame. It would be more appropriate to rename it MoleculeDataFrameDataset

class MoleculeCSVDataset(object):

@mufeili
Copy link
Contributor

mufeili commented Aug 1, 2022

While I agree this name can be misleading, directly renaming it might break too much backward compatibility. One possible workaround is to add an alias of the class MoleculeDFDataset.

@nbrosse
Copy link
Author

nbrosse commented Aug 2, 2022

Yep, good idea !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants