Skip to content

Commit 79dac56

Browse files
committed
Adding debugging message
1 parent abca997 commit 79dac56

File tree

5 files changed

+10
-4
lines changed

5 files changed

+10
-4
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
[tool.poetry]
55
name = "aws-service-catalog-puppet"
6-
version = "0.254.4"
6+
version = "0.254.5"
77
description = "Making it easier to deploy ServiceCatalog products"
88
classifiers = ["Development Status :: 5 - Production/Stable", "Intended Audience :: Developers", "Programming Language :: Python :: 3", "License :: OSI Approved :: Apache Software License", "Operating System :: OS Independent", "Natural Language :: English"]
99
homepage = "https://service-catalog-tools-workshop.com/"

servicecatalog_puppet/commands/task_reference.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ def deploy_from_task_reference(path):
6666

6767
for task_reference, task in all_tasks.items():
6868
if single_account_id: # running single account mode
69-
print("Running in single account mode")
7069
task_section_name = task.get("section_name")
7170
task_account_id = task.get("account_id")
7271
spoke_execution = str(config.get_executor_account_id()) != str(

servicecatalog_puppet/workflow/dependencies/tasks.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,9 @@ def debug(self, message):
112112
def error(self, message):
113113
logger.error(f"{self.task_reference}: {message}")
114114

115+
def exception(self, message):
116+
logger.exception(f"{self.task_reference}: {message}")
117+
115118
def warning(self, message):
116119
logger.warning(f"{self.task_reference}: {message}")
117120

servicecatalog_puppet/workflow/stack/provision_stack_task.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,11 @@ def run(self):
291291
a["Tags"] = [
292292
dict(Key=t.get("key"), Value=t.get("value")) for t in self.tags
293293
]
294-
cloudformation.create_or_update(**a)
294+
try:
295+
cloudformation.create_or_update(**a)
296+
except Exception as e:
297+
self.exception(f"Error creating or updating stack. Parameters: {a}")
298+
raise e
295299

296300
task_output["provisioned"] = self.need_to_provision
297301
task_output["section_name"] = self.section_name

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474

7575
setup_kwargs = {
7676
'name': 'aws-service-catalog-puppet',
77-
'version': '0.254.4',
77+
'version': '0.254.5',
7878
'description': 'Making it easier to deploy ServiceCatalog products',
7979
'long_description': '# aws-service-catalog-puppet\n\n![logo](./docs/logo.png) \n\n## Badges\n\n[![codecov](https://codecov.io/gh/awslabs/aws-service-catalog-puppet/branch/master/graph/badge.svg?token=e8M7mdsmy0)](https://codecov.io/gh/awslabs/aws-service-catalog-puppet)\n\n\n## What is it?\nThis is a python3 framework that makes it easier to share multi region AWS Service Catalog portfolios and makes it \npossible to provision products into accounts declaratively using a metadata based rules engine.\n\nWith this framework you define your accounts in a YAML file. You give each account a set of tags, a default region and \na set of enabled regions.\n\nOnce you have done this you can define portfolios should be shared with each set of accounts using the tags and you \ncan specify which regions the shares occur in.\n\nIn addition to this, you can also define products that should be provisioned into accounts using the same tag based \napproach. The framework will assume role into the target account and provision the product on your behalf.\n\n\n## Getting started\n\nYou can read the [installation how to](https://service-catalog-tools-workshop.com/30-how-tos/10-installation/30-service-catalog-puppet.html)\nor you can read through the [every day use](https://service-catalog-tools-workshop.com/30-how-tos/50-every-day-use.html)\nguides.\n\nYou can read the [documentation](https://aws-service-catalog-puppet.readthedocs.io/en/latest/) to understand the inner \nworkings. \n\n\n## Going further\n\nThe framework is one of a pair. The other is [aws-service-catalog-factory](https://github.com/awslabs/aws-service-catalog-factory).\nWith Service Catalog Factory you can create pipelines that deploy multi region portfolios very easily. \n\n## License\n\nThis library is licensed under the Apache 2.0 License. \n \n',
8080
'author': 'Eamonn Faherty',

0 commit comments

Comments
 (0)