-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiplication overflow in smithy runtime exponential backoff #960
Comments
we'll definitely fix the overflow but I'm a little concerned there is another bug somewhere. Are customizing the amount of retries that are allowed, e.g.? I think the default cap is 3 so I'm not sure how we'd hit overflow there. Any other logs you have would be very helpful. From my quick test, we had to get to 32 retry attempts before hitting this |
Haha yes, I am configuring 100 retries - although for no specific reason, I don't think we have ever hit that when not running into rate limiting. |
hahaha please don't do that! I think that's very unlikely to do what you want ;-) Fix is here: smithy-lang/smithy-rs#3229 |
according to your changelog this fix has been in 0.38 so I'll close it. 👍 |
|
Describe the bug
The program lists a lot of AWS resources and fetches various details about them, creating/cloning the clients as needed per region/resource type. It looks like that in certain scenarios this leads to a multiplication overflow.
Expected Behavior
No overflow.
Current Behavior
After many requests this randomly occurs:
Reproduction Steps
Uncertain
Possible Solution
Cap the exponential backoff waiting time?
Additional Information/Context
No response
Version
Environment details (OS name and version, etc.)
stable-aarch64-apple-darwin
Logs
No response
The text was updated successfully, but these errors were encountered: