Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ByteStream: add support for from impl Read + Seek #1183

Closed
2 tasks done
i18nsite opened this issue Sep 4, 2024 · 2 comments
Closed
2 tasks done

ByteStream: add support for from impl Read + Seek #1183

i18nsite opened this issue Sep 4, 2024 · 2 comments
Labels
feature-request A feature should be added or improved. wontfix We have determined that we will not resolve the issue.

Comments

@i18nsite
Copy link

i18nsite commented Sep 4, 2024

Describe the feature

ByteStream: add support for impl Read

Use Case

I can pipeline from one reader to s3

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

A note for the community

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment
@i18nsite i18nsite added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 4, 2024
@i18nsite i18nsite changed the title ByteStream: add support for impl Read ByteStream: add support for from impl Read Sep 4, 2024
@i18nsite i18nsite changed the title ByteStream: add support for from impl Read ByteStream: add support for from impl Read + Seek Sep 4, 2024
@aajtodd
Copy link
Contributor

aajtodd commented Sep 4, 2024

Thanks for the feature request. ByteStream is modeled as an async API and trying to provide a sync Read implementation is not something we plan to support. We can't support Seek because not all streams are seekable.

You can turn a ByteStream into tokio::AsyncRead (see docs). You can then maybe leverage a crate from the ecosystem to bridge the sync and async worlds (example).

I'm going to go ahead and close this as we don't have plans to support this directly on ByteStream.

@aajtodd aajtodd closed this as completed Sep 4, 2024
@aajtodd aajtodd added wontfix We have determined that we will not resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. wontfix We have determined that we will not resolve the issue.
Projects
None yet
Development

No branches or pull requests

2 participants