Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MqttClientConnection port datatype #715

Closed
jcosentino11 opened this issue Nov 10, 2023 · 1 comment
Closed

MqttClientConnection port datatype #715

jcosentino11 opened this issue Nov 10, 2023 · 1 comment
Labels
bug This issue is a bug. CRT/IoT p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.

Comments

@jcosentino11
Copy link

jcosentino11 commented Nov 10, 2023

Describe the bug

For MQTT3 connections, it looks like signed short is being used rather than unsigned (jchar)

Expected Behavior

To be able to connect with MqttClientConnection using ports > 32767

Current Behavior

software.amazon.awssdk.crt.mqtt.MqttException: Port must be betweeen 0 and 32767
	at software.amazon.awssdk.crt.mqtt.MqttClientConnection.connect(MqttClientConnection.java:315)

Reproduction Steps

MqttConnectionConfig conf = new MqttConnectionConfig();
conf.setPort(40000);
...
MqttClientConnection conn = new MqttClientConnection(conf);
conn.connect();

Possible Solution

No response

Additional Information/Context

No response

aws-crt-java version used

0.21.14

Java version used

8

Operating System and version

N/A

@jcosentino11 jcosentino11 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 10, 2023
@jcosentino11 jcosentino11 changed the title [MqttClientConnection] port datatype MqttClientConnection port datatype Nov 10, 2023
@bretambrose bretambrose added pending-release This issue will be fixed by an approved PR that hasn't been released yet. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 14, 2023
@jmklix jmklix added the CRT/IoT label Nov 15, 2023
@jmklix jmklix added the p2 This is a standard priority issue label Nov 29, 2023
@jmklix
Copy link
Member

jmklix commented Dec 4, 2023

This should be fixed with the latest release. Please let us know if you have any other problems with this sdk.

@jmklix jmklix closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. CRT/IoT p2 This is a standard priority issue pending-release This issue will be fixed by an approved PR that hasn't been released yet.
Projects
None yet
Development

No branches or pull requests

3 participants