Getting the error error storing credentials - err: exit status 1, out: not implemented

[dean-hpe]

I'm running a Ubuntu22 VM using VMWare Fusion 13. The host OS is MacOS on M1 Apple silicon. I build docker-credential-ecr-login following the docs like this:

go install github.com/awslabs/amazon-ecr-credential-helper/ecr-login/cli/docker-credential-ecr-login@latest

The following command gives this error:

aws ecr get-login-password --region us-west-2 | docker login --username AWS --password-stdin <ID>.dkr.ecr.us-west-2.amazonaws.com
Error saving credentials: error storing credentials - err: exit status 1, out: `not implemented`

Lots of people have seen this and none of the suggestions have worked.

[merlinran]

The culprit is https://github.com/awslabs/amazon-ecr-credential-helper/blob/main/ecr-login/ecr.go#L75 . Just changing both methods to return nil fixed the error. Will have a PR soon

[pauldthomson]

I don't know if that's the correct fix, rather shouldn't it be doing what this line is doing?
That function is called by docker login which you don't technically need to use with this helper, but I'm not sure if that's breaking the credential helper protocol?

[jaswanthikolla]

We are facing this issue too. When you have a common Github action runner with different use cases, there are users who uses this ECR login aws action and users who does docker push directly.

Any update on this issue?

For anyone else facing the same issue, Workaround is:

{
    "credHelpers": {
		"xxx.dkr.ecr.us-east-2.amazonaws.com": "ecr-login"
	}
}

[pauldthomson]

@jaswanthikolla presumably that only fixes the error for non-ECR use-cases?

[jaswanthikolla]

Workaround fixes ECR use cases. It works for following use case

aws ecr get-login-password --region us-west-2 | docker login --username AWS --password-stdin <ID>.dkr.ecr.us-west-2.amazonaws.com

[pauldthomson]

@jaswanthikolla ah right, it fixes it for ECR repos that don't match the URL as it's not going to invoke the helper at all..
I still think this helper should probably just implement the Add function and store the token 🤷‍♂️