Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider tagging module "ecr-login"? #492

Open
Rick-xuy opened this issue Feb 18, 2023 · 1 comment
Open

Consider tagging module "ecr-login"? #492

Rick-xuy opened this issue Feb 18, 2023 · 1 comment

Comments

@Rick-xuy
Copy link

I found that some packages, say github.com/awslabs/amazon-ecr-credential-helper/ecr-login/api, are placed in submodule github.com/awslabs/amazon-ecr-credential-helper/ecr-login instead of root module.

However, it seems that submodule github.com/awslabs/amazon-ecr-credential-helper/ecr-login is not tagged. According to go docs, submodule should be tagged like relative-path-to-root/vX.X.X.
At now, when trying to import package github.com/awslabs/amazon-ecr-credential-helper/ecr-login/api, downstream would depends on pseudo-version of module github.com/awslabs/amazon-ecr-credential-helper/ecr-login.

github.com/awslabs/amazon-ecr-credential-helper/ecr-login v0.0.0-20200626212615-d883bee51b56

I think it is not very readable and difficult to upgrade. This is not conductive to version control either.
So, I propose whether it is possible to tag submodule properly. For example, ecr-login/v0.0.1, ecr-login/v0.6.0etc, so that other project can use tag to import this module in go.mod.

@ppg
Copy link

ppg commented Aug 16, 2023

I would like to bump this as it makes installing the tool from source behave poorly per golang's modules specifications. If you follow the instructions and run:

go install github.com/awslabs/amazon-ecr-credential-helper/ecr-login/cli/docker-credential-ecr-login@latest

You then get a version like:

$ docker-credential-ecr-login version
 (github.com/docker/docker-credential-helpers) v0.0.0+unknown

Whereas if the tag was ecr-login/v0.7.1 instead of v0.7.1 it would install the correct version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants