Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update etcdadm-controller to loop through all the external IPs and pass the healthcheck if etcd endpoint is connected to any of the IPs #8735

Open
panktishah26 opened this issue Sep 9, 2024 · 0 comments
Labels
Milestone

Comments

@panktishah26
Copy link
Member

panktishah26 commented Sep 9, 2024

Currently, the etcd health check fails if we add a secondary IP on an etcd VMs. The etcdadm controller finds the recently added Ip's frequency unhealthy, adds the machine to the unhealthy list, brings down the current etcd vm and goes ahead with bringing up new etcd, cp or brings down the entire cluster in case of 1 control plane.

To resolve this issue, we should loop through all the external IPs machine object have and should pass the health check if etcd is available on any of the IPs. https://github.com/aws/etcdadm-controller/blob/main/controllers/helpers.go#L159-L188

-managed-etcd secret doesn't have endpoint IP in the etcd certificate but we should make sure this change is not affecting the certificate or any other place.

@vivek-koppuru vivek-koppuru added this to the v0.21.0 milestone Sep 10, 2024
@vivek-koppuru vivek-koppuru modified the milestones: v0.21.0, v0.22.0 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants