Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage package bundle controllers in response to Full Cluster Lifecycle events. #807

Closed
ewollesen opened this issue Feb 6, 2023 · 9 comments
Assignees

Comments

@ewollesen
Copy link
Contributor

When a new workload cluster is created via the full cluster lifecycle (FCL) API, a new package bundle controller must be created for the cluster.

At present, the packages controller is installed with a management (or self-managed) cluster, but the packages controller isn't notified about the creation of the new cluster.

Proposed solution:

Logic should be added to the packages controller's reconcile loop to handle the creation/deletion of package bundle controllers in response to FCL events.

With that logic in place, adding a Watch on the packages controller would trigger reconcile loop immediately, and that'd be what I think we expect.

Part of #797

@ewollesen ewollesen self-assigned this Feb 6, 2023
@ewollesen
Copy link
Contributor Author

ewollesen commented Feb 14, 2023

I'm going to get a PR for this pushed up today. It isn't complete yet, as I've been blocked in my testing, but it's a step. I'll link the PR when I push it.

Still to do before the PR will be ready to merge:

  • Perform proof of concept testing (i.e. make sure it works)
  • Check that deletion works
  • Add unit tests
  • Add e2e tests

Then I can start working on making sure packages can be installed, but that'll be a diff issue.

@ewollesen
Copy link
Contributor Author

ewollesen commented Feb 16, 2023

Latest push is now working in a nominal sense. There are still issues regarding package bundle application warnings to work out, and tests to write, but it is, at a base level, functional.

Edit: link to current commit: aws/eks-anywhere@146eb63

@ewollesen
Copy link
Contributor Author

I've implemented the changes that we talked about in our document review to not wait for a package bundle to be activated. I'll get another commit pushed later today.

@ewollesen
Copy link
Contributor Author

latest is here: ewollesen/eks-anywhere@1df06ad

ewollesen pushed a commit to ewollesen/eks-anywhere-packages that referenced this issue Feb 22, 2023
These permissions will allow the eksa-controller to delete package bundle
controller helm installations completely, and without error.

The namespace in question is the workload clusters,
e.g. eksa-packages-my-workload-cluster.

The secret in question is the registry-mirror-secret that is created for
workload clusters (regardless of whether or registry mirror is in use).

Part of aws#807.
ewollesen pushed a commit to ewollesen/eks-anywhere-packages that referenced this issue Feb 22, 2023
These permissions will allow the eksa-controller to delete package bundle
controller helm installations completely, and without error.

The namespace in question is the workload clusters,
e.g. eksa-packages-my-workload-cluster.

The secret in question is the registry-mirror-secret that is created for
workload clusters (regardless of whether or registry mirror is in use).

Part of aws#807.
@ewollesen
Copy link
Contributor Author

#833 - adds some permissions to allow deletion without errors

eks-distro-bot pushed a commit that referenced this issue Feb 22, 2023
)

These permissions will allow the eksa-controller to delete package bundle
controller helm installations completely, and without error.

The namespace in question is the workload clusters,
e.g. eksa-packages-my-workload-cluster.

The secret in question is the registry-mirror-secret that is created for
workload clusters (regardless of whether or registry mirror is in use).

Part of #807.
@ewollesen
Copy link
Contributor Author

Latest code is at ewollesen/eks-anywhere@e9e5017

Will be starting on adding tests next.

@ewollesen
Copy link
Contributor Author

Now working on e2e tests

@ewollesen
Copy link
Contributor Author

aws/eks-anywhere#4970

@ewollesen
Copy link
Contributor Author

Completed along with PR#4970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant