-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage package bundle controllers in response to Full Cluster Lifecycle events. #807
Comments
I'm going to get a PR for this pushed up today. It isn't complete yet, as I've been blocked in my testing, but it's a step. I'll link the PR when I push it. Still to do before the PR will be ready to merge:
Then I can start working on making sure packages can be installed, but that'll be a diff issue. |
Latest push is now working in a nominal sense. There are still issues regarding package bundle application warnings to work out, and tests to write, but it is, at a base level, functional. Edit: link to current commit: aws/eks-anywhere@146eb63 |
I've implemented the changes that we talked about in our document review to not wait for a package bundle to be activated. I'll get another commit pushed later today. |
latest is here: ewollesen/eks-anywhere@1df06ad |
These permissions will allow the eksa-controller to delete package bundle controller helm installations completely, and without error. The namespace in question is the workload clusters, e.g. eksa-packages-my-workload-cluster. The secret in question is the registry-mirror-secret that is created for workload clusters (regardless of whether or registry mirror is in use). Part of aws#807.
These permissions will allow the eksa-controller to delete package bundle controller helm installations completely, and without error. The namespace in question is the workload clusters, e.g. eksa-packages-my-workload-cluster. The secret in question is the registry-mirror-secret that is created for workload clusters (regardless of whether or registry mirror is in use). Part of aws#807.
#833 - adds some permissions to allow deletion without errors |
) These permissions will allow the eksa-controller to delete package bundle controller helm installations completely, and without error. The namespace in question is the workload clusters, e.g. eksa-packages-my-workload-cluster. The secret in question is the registry-mirror-secret that is created for workload clusters (regardless of whether or registry mirror is in use). Part of #807.
Latest code is at ewollesen/eks-anywhere@e9e5017 Will be starting on adding tests next. |
Now working on e2e tests |
Completed along with PR#4970 |
When a new workload cluster is created via the full cluster lifecycle (FCL) API, a new package bundle controller must be created for the cluster.
At present, the packages controller is installed with a management (or self-managed) cluster, but the packages controller isn't notified about the creation of the new cluster.
Proposed solution:
Logic should be added to the packages controller's reconcile loop to handle the creation/deletion of package bundle controllers in response to FCL events.
With that logic in place, adding a Watch on the packages controller would trigger reconcile loop immediately, and that'd be what I think we expect.
Part of #797
The text was updated successfully, but these errors were encountered: