Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS.Tools.Installer module should check for updates and provide a warning with suggested update command. #321

Open
1 of 2 tasks
KaylorDave opened this issue May 1, 2023 · 1 comment
Labels
feature-request A feature should be added or improved. module/powershell-cmdlets p2 This is a standard priority issue queued xs Effort estimation: tiny

Comments

@KaylorDave
Copy link

Describe the feature

Due, I assume, to circular dependency issues, the AWS.Tools.Installer module does not update itself unlike all other AWS.Tools.* modules. However, there is no indication that your module is out of date unless you check the PSGallery or run commands such as Find-Module, Update-Module, etc. I believe we should implement a check inside Install-AWSToolsModule and Update-AWSToolsModule that will check for a new version of the module when run, and if one is found, output a warning message suggesting an update and how it can be updated (via Install-Module -Name AWS.Tools.Installer -Scope CurrentUser or Update-Module -Name AWS.Tools.Installer). This would greatly improve the customer experience of not just this module but all AWS.Tools.* modules when someone is using the Installer module to maintain their module collection.

Use Case

There is no current way for a customer of the AWS.Tools.Installer module to know that their module is out of date when it is being run, despite the fact that this module explicitly checks for all other AWS.Tools.* modules for updates. This makes for a poor customer experience, especially since this module has been greatly improved in recent versions.

Proposed Solution

Implement a check using Find-Module -Name AWS.Tools.Installer along with a corresponding override switch parameter (perhaps -NoUpdateCheck) on both Install-AWSToolsModuleandUpdate-AWSToolsModule` commands that will warn if a newer version exists. It would require a slight change to Get-AWSToolsModule as well to remove the filter of the Installer module.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Tools for PowerShell version used

AWS.Tools.Installer 1.0.2.4

PowerShell version used

Name                           Value
----                           -----
PSVersion                      7.3.4
PSEdition                      Core
GitCommitId                    7.3.4
OS                             Microsoft Windows 10.0.22000
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Operating System and version

Windows 11

@KaylorDave KaylorDave added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 1, 2023
@ashishdhingra ashishdhingra added module/powershell-cmdlets needs-review p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels May 2, 2023
@ashishdhingra
Copy link
Contributor

ashishdhingra commented May 2, 2023

Appears to be a useful feature request.

@KaylorDave Thanks for submitting the feature request. Kindly note that there is a check here if you attempt to install/update AWS.Tools.Installer module, it throws an error AWS.Tools.Installer cannot be used to install AWS.Tools.Installer. Use Update-Module instead.. Feel free to contribute a PR that could be reviewed by the team.

Thanks,
Ashish

@ashishdhingra ashishdhingra added p2 This is a standard priority issue xs Effort estimation: tiny queued and removed needs-review p3 This is a minor priority issue labels May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. module/powershell-cmdlets p2 This is a standard priority issue queued xs Effort estimation: tiny
Projects
None yet
Development

No branches or pull requests

2 participants