unreliable test: checkNoNewAccess should handle Terraform Plan correctly:

[Hweinstock]

Test Details

• Name of test: checkNoNewAccess should handle Terraform Plan correctly:
• OS of failure: Mac
• VSCode version of failure (minimum/insider/stable): minimum
• Link to failing run: https://github.com/aws/aws-toolkit-vscode/actions/runs/13206848909/job/36871882448
• Link to failing test:

  aws-toolkit-vscode/packages/core/src/test/awsService/accessanalyzer/iamPolicyChecks.test.ts

  Lines 346 to 376 in 67f053c

  	it('checkNoNewAccess should handle Terraform Plan correctly', async function () {
  	const documentType = 'Terraform Plan'
  	const policyType = 'Identity'
  	const referenceDocument = '{"some": "reference"}'
  	const document = 'path/to/terraform.json'
  	const cfnParameterPath = 'path/to/cfn-params'
  	sandbox.stub(IamPolicyChecksWebview, 'editedDocumentFileName').value(document)
  	sandbox.stub(iamPolicyChecks, 'isTerraformPlan').returns(true)
  	sandbox.stub(iamPolicyChecks, 'isCloudFormationTemplate').returns(false)
  	executeCustomPolicyChecksCommandStub = sandbox.stub(fakePolicyChecksWebview, 'executeCustomPolicyChecksCommand')
  	await fakePolicyChecksWebview.checkNoNewAccess(documentType, policyType, referenceDocument, cfnParameterPath)
  	// We do not want to validate the path of the temporary folder, so we check every other field instead of the entire args
  	assert(executeCustomPolicyChecksCommandStub.called)
  	const actualCommand = executeCustomPolicyChecksCommandStub.getCalls()[0].args[0]
  	assert.deepStrictEqual(actualCommand.command, 'tf-policy-validator')
  	assert.deepStrictEqual(actualCommand.args[0], 'check-no-new-access')
  	assert.deepStrictEqual(actualCommand.args[2], document)
  	assert.deepStrictEqual(actualCommand.args[4], 'us-east-1')
  	assert.deepStrictEqual(actualCommand.args[6], `${globals.context.asAbsolutePath(defaultTerraformConfigPath)}`)
  	assert.deepStrictEqual(actualCommand.args[10], policyType)
  	assert.deepStrictEqual(actualCommand.cfnParameterPathExists, true)
  	assert.deepStrictEqual(actualCommand.documentType, documentType)
  	assert.deepStrictEqual(actualCommand.checkType, 'CheckNoNewAccess')
  	assert.deepStrictEqual(actualCommand.referencePolicyType, policyType)
  	assert(onCustomPolicyCheckResponseFireSpy.notCalled)
  	})

Log of Test Failure

checkNoNewAccess should handle Terraform Plan correctly:

      AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:

  (0, assert_1.default)(executeCustomPolicyChecksCommandStub.called)

      + expected - actual

      -false
      +true

Additional Information