From 7f4517d8219224aa5bf7fe8c4ab0935331e19c1d Mon Sep 17 00:00:00 2001 From: seshubaws <116689586+seshubaws@users.noreply.github.com> Date: Tue, 5 Nov 2024 12:05:07 -0800 Subject: [PATCH] fix(lambda): drop delete action for lambda, s3 in AppBuilder #5922 ## Problem When resources are provisioned and controlled through a SAM template, customers should never modify resources directly as this such action would create drift in the CFN template. ## Solution Removed action to delete a Lambda or S3 bucket in the AppBuilder section --- .../Bug Fix-f6bb74e5-14cd-4e63-bc24-5e8e82dbaf46.json | 4 ++++ packages/toolkit/package.json | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 packages/toolkit/.changes/next-release/Bug Fix-f6bb74e5-14cd-4e63-bc24-5e8e82dbaf46.json diff --git a/packages/toolkit/.changes/next-release/Bug Fix-f6bb74e5-14cd-4e63-bc24-5e8e82dbaf46.json b/packages/toolkit/.changes/next-release/Bug Fix-f6bb74e5-14cd-4e63-bc24-5e8e82dbaf46.json new file mode 100644 index 00000000000..922654bd4d5 --- /dev/null +++ b/packages/toolkit/.changes/next-release/Bug Fix-f6bb74e5-14cd-4e63-bc24-5e8e82dbaf46.json @@ -0,0 +1,4 @@ +{ + "type": "Bug Fix", + "description": "AWS Lambda: Removed action to delete a Lambda or S3 bucket in the AppBuilder section as resources created through IaC frameworks should not be directly modified since this creates drift" +} diff --git a/packages/toolkit/package.json b/packages/toolkit/package.json index a924f48e36e..e538b74df18 100644 --- a/packages/toolkit/package.json +++ b/packages/toolkit/package.json @@ -1652,7 +1652,7 @@ }, { "command": "aws.deleteLambda", - "when": "view =~ /^(aws.explorer|aws.appBuilder|aws.appBuilderForFileExplorer)$/ && viewItem =~ /^(awsRegionFunctionNode|awsRegionFunctionNodeDownloadable)$/ || viewItem == awsAppBuilderDeployedNode", + "when": "view =~ /^(aws.explorer)$/ && viewItem =~ /^(awsRegionFunctionNode|awsRegionFunctionNodeDownloadable)$/", "group": "4@1" }, { @@ -1877,7 +1877,7 @@ }, { "command": "aws.s3.deleteBucket", - "when": "view =~ /^(aws.explorer|aws.appBuilder|aws.appBuilderForFileExplorer)$/ && viewItem == awsS3BucketNode", + "when": "view =~ /^(aws.explorer)$/ && viewItem == awsS3BucketNode", "group": "3@1" }, {