diff --git a/README.quickstart.cloud9.md b/README.quickstart.cloud9.md index 1a3cec09722..aeab599c130 100644 --- a/README.quickstart.cloud9.md +++ b/README.quickstart.cloud9.md @@ -10,6 +10,7 @@ See [Setup](#additional-setup-steps) for installation requirements, or [Get help - [AWS Explorer](#ui-components-aws-expl) - CloudFormation stacks - Lambda functions + - S3 explorer - [AWS Serverless Applications (SAM)](#sam-and-lambda) - [`AWS:` Commands](#aws-commands) diff --git a/package.json b/package.json index 9459f1b9980..4b336ecf81b 100644 --- a/package.json +++ b/package.json @@ -690,10 +690,6 @@ { "command": "aws.stepfunctions.publishStateMachine", "when": "!isCloud9" - }, - { - "command": "aws.quickStart", - "when": "!isCloud9" } ], "editor/title": [ @@ -758,7 +754,7 @@ }, { "command": "aws.quickStart", - "when": "view == aws.explorer && !isCloud9", + "when": "view == aws.explorer", "group": "y_quickStart@1" }, { diff --git a/src/extension.ts b/src/extension.ts index 17571072e2a..b77bceb856d 100644 --- a/src/extension.ts +++ b/src/extension.ts @@ -232,9 +232,7 @@ export async function activate(context: vscode.ExtensionContext) { }) } - if (!isCloud9()) { - showWelcomeMessage(context) - } + showWelcomeMessage(context) await loginWithMostRecentCredentials(toolkitSettings, loginManager) diff --git a/src/shared/extensionUtilities.ts b/src/shared/extensionUtilities.ts index 42f29f8f9a3..3fb6b206363 100644 --- a/src/shared/extensionUtilities.ts +++ b/src/shared/extensionUtilities.ts @@ -225,19 +225,24 @@ export function setMostRecentVersion(context: vscode.ExtensionContext): void { /** * Shows a message with a link to the quickstart page. + * In cloud9, directly opens quickstart instead */ -async function showQuickstartPrompt(): Promise { - const view = localize('AWS.command.quickStart', 'View Quick Start') - const prompt = await vscode.window.showInformationMessage( - localize( - 'AWS.message.prompt.quickStart.toastMessage', - 'You are now using AWS Toolkit version {0}', - pluginVersion - ), - view - ) - if (prompt === view) { +async function showOrPromptQuickstart(): Promise { + if (isCloud9()) { vscode.commands.executeCommand('aws.quickStart') + } else { + const view = localize('AWS.command.quickStart', 'View Quick Start') + const prompt = await vscode.window.showInformationMessage( + localize( + 'AWS.message.prompt.quickStart.toastMessage', + 'You are now using AWS Toolkit version {0}', + pluginVersion + ), + view + ) + if (prompt === view) { + vscode.commands.executeCommand('aws.quickStart') + } } } @@ -262,13 +267,12 @@ export function showWelcomeMessage(context: vscode.ExtensionContext): void { ) return } - try { if (isDifferentVersion(context)) { setMostRecentVersion(context) // the welcome toast should be nonblocking. // tslint:disable-next-line: no-floating-promises - showQuickstartPrompt() + showOrPromptQuickstart() } } catch (err) { // swallow error and don't block extension load