Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The type of Status in the DescribeEnvironmentHealthResult interfac is incorrect. #6567

Open
3 of 4 tasks
jhpung opened this issue Oct 16, 2024 · 2 comments
Open
3 of 4 tasks
Assignees
Labels
bug This issue is a bug. p2 This is a standard priority issue service-api This issue is due to a problem in a service API, not the SDK implementation.

Comments

@jhpung
Copy link

jhpung commented Oct 16, 2024

Checkboxes for prior research

Describe the bug

Currently, the type is set to EnvironmentHealth, but it should be specified as EnvironmentStatus to match the response.

Regression Issue

  • Select this option if this issue appears to be a regression.

SDK version number

@aws-sdk/[email protected]

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

20.18.0

Reproduction Steps

  1. Send a DescribeEnvironmentHealthCommand
  2. The received output and the typeof output's status do not match with EnvironmentHealth type.

Observed Behavior

DescribeEnvironmentHealthCommandOutput.Status is Ready but it's type is EnvironmentHealth that doesn't matched

Expected Behavior

DescribeEnvironmentHealthCommandOutput.Status's type should be EnvironmentStatus

Possible Solution

No response

Additional Information/Context

No response

@jhpung jhpung added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 16, 2024
@aBurmeseDev aBurmeseDev self-assigned this Oct 16, 2024
@kuhe kuhe added the service-api This issue is due to a problem in a service API, not the SDK implementation. label Oct 17, 2024
@kuhe
Copy link
Contributor

kuhe commented Oct 17, 2024

@aBurmeseDev please create a ticket with the service team to confirm the intended model structure. I have closed the related PR #6568 because it cannot be modified in this repository.

@aBurmeseDev
Copy link
Member

Hi @jhpung - thanks for reaching out.

As my colleague mentioned above, The modifications related to service models need to be handled by the respective service teams upstream and we do not make direct changes to the models within SDK.

I have initiated an internal communication with the concerned service team to inquire about the type and model structure and will keep you updated here. (Ref: P162555824)

Best,
John

@aBurmeseDev aBurmeseDev added p3 This is a minor priority issue p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. p3 This is a minor priority issue labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue service-api This issue is due to a problem in a service API, not the SDK implementation.
Projects
None yet
Development

No branches or pull requests

3 participants