From 75577b44bea1bcaf95a43b6c85b415c6fb164fce Mon Sep 17 00:00:00 2001 From: hdavidh Date: Mon, 3 Feb 2025 17:16:52 -0800 Subject: [PATCH] Address comments --- .../next-release/feature-NettyNIOHTTPClient-8f8589d.json | 6 ++++++ .../awssdk/http/nio/netty/NettyNioAsyncHttpClient.java | 4 ---- 2 files changed, 6 insertions(+), 4 deletions(-) create mode 100644 .changes/next-release/feature-NettyNIOHTTPClient-8f8589d.json diff --git a/.changes/next-release/feature-NettyNIOHTTPClient-8f8589d.json b/.changes/next-release/feature-NettyNIOHTTPClient-8f8589d.json new file mode 100644 index 000000000000..6feae101e27c --- /dev/null +++ b/.changes/next-release/feature-NettyNIOHTTPClient-8f8589d.json @@ -0,0 +1,6 @@ +{ + "type": "feature", + "category": "Netty NIO HTTP Client", + "contributor": "", + "description": "Fallback to prior knowledge if default client setting is ALPN and request has HTTP endpoint" +} diff --git a/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.java b/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.java index db973050326e..8c37f0db3ccf 100644 --- a/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.java +++ b/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/NettyNioAsyncHttpClient.java @@ -140,10 +140,6 @@ private void failIfAlpnUsedWithHttp(AsyncExecuteRequest request) { if (isAlpnUserConfigured) { throw new UnsupportedOperationException("ALPN can only be used with HTTPS, not HTTP."); } - if (protocolNegotiation == ProtocolNegotiation.ALPN) { - log.debug(null, () -> "Default client protocol negotiation is ALPN, but request endpoint is HTTP. Prior " - + "knowledge negotiation will be used instead"); - } } }