Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing debug PDB files when building and installing with cmake #2963

Open
nanocom opened this issue May 15, 2024 · 4 comments
Open

Missing debug PDB files when building and installing with cmake #2963

nanocom opened this issue May 15, 2024 · 4 comments
Labels
bug This issue is a bug. p3 This is a minor priority issue

Comments

@nanocom
Copy link

nanocom commented May 15, 2024

Describe the bug

When building the SDK in debug mode with cmake, it generates the .pdb files alongside the dlls in the build/src folder
But when installing, the pdb files are not copied in the install folder

In the build folder:
image

In the install folder:
image

I would like these debug files to be able to have more detailed stacktraces on sentry

Expected Behavior

Copy the pdb files in the install folder along the dlls in debug mode

Current Behavior

Pdb files are not copied alongside the dll files during the cmake installation

Reproduction Steps

Build the sdk in debug mode

Possible Solution

Maybe add something like this somewhere in the cmake file?

if (MSVC)
    install(FILES $<TARGET_PDB_FILE:MyExecutable> DESTINATION bin OPTIONAL)
endif()

Additional Information/Context

My build script:

cmake -B build `
-DCMAKE_BUILD_TYPE=Debug `
-DCMAKE_INSTALL_PREFIX=install `
-DENABLE_TESTING=OFF `
-DAUTORUN_UNIT_TESTS=OFF `
-DCPP_STANDARD=20 `
-DBUILD_ONLY="s3;transfer"

cmake --build build --config=Debug

cmake --install build --prefix install --config Debug

AWS CPP SDK version used

1.11.328

Compiler and Version used

MSVC 14.39.33519

Operating System and version

Windows 11

@nanocom nanocom added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 15, 2024
@jmklix
Copy link
Member

jmklix commented May 24, 2024

This is a duplicate of this issue: #1936
closing this one

@jmklix jmklix closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

@nanocom
Copy link
Author

nanocom commented May 25, 2024

i don't think it's a duplicate, the pdb files are well generated when compiling on my computer, but they just aren't copied

@nanocom
Copy link
Author

nanocom commented May 25, 2024

@jmklix

@jmklix jmklix reopened this May 28, 2024
@jmklix jmklix added investigating This issue is being investigated and/or work is in progress to resolve the issue. p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels May 28, 2024
@jmklix jmklix removed the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

2 participants