Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expire token error code? #1843

Closed
lsong0905 opened this issue Jan 13, 2022 · 2 comments · May be fixed by #2062
Closed

Expire token error code? #1843

lsong0905 opened this issue Jan 13, 2022 · 2 comments · May be fixed by #2062
Assignees
@KaibaLopez
Labels
closed-for-staleness guidance Question that needs advice or information. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days.

Comments

@lsong0905
Copy link

Describe the issue

Hello,

When I issue a S3 request(PUT, GET, etc) with an expire credentials (generated by STS service), the S3 SDK seems returning UNKNOWN = 100 error code from S3Errors.h. The error message "ExpiredToken:Unable to parse ExceptionName: ExpiredToken Message: The provided token has expired." , on the other hand, seems containing some hint that indicates why the request failed.

Other than parsing the error message, is there any better way to verify the request failed due to "ExpiredToken"? I expected to receive an error code that maps to "ExpiredToken" in S3Errors.h, but it is returning UNKNOWN = 100 error code. I am not certain if this is intentional.

Thank you in advance!

Steps to Reproduce

No response

Current behavior

No response

AWS CPP SDK version used

1.7.29

compiler and version used

na

Operating System and version

na
@lsong0905 lsong0905 added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Jan 13, 2022
@KaibaLopez
Copy link
Contributor

Hi @lsong0905 ,
Short answer is no.
Error handling is always somewhat problematic for the SDK as it is heavily limited to what the service APIs models provide. We have to keep parity with them and so there is a limit to what we can change there, and the api sends error 100 (which can mean anything really) and the message with the description. Admittedly, it could be "catched" by reading the error but making those kinds of checks is a rabbit hole we are just not looking to get into.

Let me know if that answers your question.

@KaibaLopez KaibaLopez added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. and removed needs-triage This issue or PR still needs to be triaged. labels Jan 18, 2022
@KaibaLopez KaibaLopez self-assigned this Jan 18, 2022
@github-actions
Copy link

Greetings! It looks like this issue hasn’t been active in longer than a week. We encourage you to check if this is still an issue in the latest release. Because it has been longer than a week since the last update on this, and in the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or add an upvote to prevent automatic closure, or if the issue is already closed, please feel free to open a new one.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jan 21, 2022
@pcmoritz pcmoritz mentioned this issue Aug 29, 2022
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaibaLopez KaibaLopez

Labels
closed-for-staleness guidance Question that needs advice or information. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set BAD_REQUEST error code for 400 error instead of UNKNOWN pcmoritz/aws-sdk-cpp
2 participants
@KaibaLopez @lsong0905