adding mock S3crt

Author: pulimsr

cmake/sdksCommon.cmake

@@ -106,7 +106,7 @@ list(APPEND SDK_TEST_PROJECT_LIST "rds:tests/aws-cpp-sdk-rds-integration-tests")
 list(APPEND SDK_TEST_PROJECT_LIST "redshift:tests/aws-cpp-sdk-redshift-integration-tests")
 list(APPEND SDK_TEST_PROJECT_LIST "s3:tests/aws-cpp-sdk-s3-integration-tests")
 list(APPEND SDK_TEST_PROJECT_LIST "s3:tests/aws-cpp-sdk-s3-unit-tests")
-list(APPEND SDK_TEST_PROJECT_LIST "s3-crt:tests/aws-cpp-sdk-s3-crt-integration-tests")
+list(APPEND SDK_TEST_PROJECT_LIST "s3-crt:tests/aws-cpp-sdk-s3-crt-integration-tests,tests/aws-cpp-sdk-s3-crt-unit-tests")
 list(APPEND SDK_TEST_PROJECT_LIST "s3-encryption:tests/aws-cpp-sdk-s3-encryption-tests,tests/aws-cpp-sdk-s3-encryption-integration-tests")
 list(APPEND SDK_TEST_PROJECT_LIST "s3control:tests/aws-cpp-sdk-s3control-integration-tests")
 list(APPEND SDK_TEST_PROJECT_LIST "sns:tests/aws-cpp-sdk-sns-integration-tests")

generated/src/aws-cpp-sdk-s3-crt/source/S3CrtClient.cpp

@@ -687,7 +687,7 @@ void S3CrtClient::S3CrtRequestFinishCallback(struct aws_s3_meta_request* meta_re
 
 Aws::Client::XmlOutcome S3CrtClient::GenerateXmlOutcome(const std::shared_ptr<HttpResponse>& response) const {
   Aws::Client::HttpResponseOutcome httpOutcome;
-  if (response->HasClientError() || AWSClient::DoesResponseGenerateError(response)) {
+  if (AWSClient::DoesResponseGenerateError(response)) {
     AWS_LOGSTREAM_DEBUG(ALLOCATION_TAG, "Request returned error. Attempting to generate appropriate error codes from response");
     auto error = BuildAWSError(response);
     httpOutcome = HttpResponseOutcome(std::move(error));

tests/aws-cpp-sdk-s3-crt-unit-tests/CMakeLists.txt

@@ -0,0 +1,33 @@
+add_project(aws-cpp-sdk-s3-crt-unit-tests
+        "Unit Tests for the S3 crt SDK Client"
+        aws-cpp-sdk-s3-crt
+        testing-resources
+        aws_test_main
+        aws-cpp-sdk-core)
+
+add_definitions(-DRESOURCES_DIR="${CMAKE_CURRENT_SOURCE_DIR}/resources")
+
+if(MSVC AND BUILD_SHARED_LIBS)
+    add_definitions(-DGTEST_LINKED_AS_SHARED_LIBRARY=1)
+endif()
+
+enable_testing()
+
+if(PLATFORM_ANDROID AND BUILD_SHARED_LIBS)
+    add_library(${PROJECT_NAME} ${CMAKE_CURRENT_SOURCE_DIR}/S3crtUnitTests.cpp)
+else()
+    add_executable(${PROJECT_NAME} ${CMAKE_CURRENT_SOURCE_DIR}/S3crtUnitTests.cpp)
+endif()
+
+set_compiler_flags(${PROJECT_NAME})
+set_compiler_warnings(${PROJECT_NAME})
+
+target_link_libraries(${PROJECT_NAME} ${PROJECT_LIBS})
+
+if(MSVC AND BUILD_SHARED_LIBS)
+    set_target_properties(${PROJECT_NAME} PROPERTIES LINK_FLAGS "/DELAYLOAD:aws-cpp-sdk-s3-crt.dll /DELAYLOAD:aws-cpp-sdk-core.dll")
+    target_link_libraries(${PROJECT_NAME} delayimp.lib)
+endif()
+
+include(GoogleTest)
+gtest_add_tests(TARGET ${PROJECT_NAME})

tests/aws-cpp-sdk-s3-crt-unit-tests/S3crtUnitTests.cpp

@@ -0,0 +1,37 @@
+#include <gtest/gtest.h>
+#include <aws/core/Aws.h>
+#include <aws/s3-crt/S3CrtClient.h>
+#include <aws/s3-crt/model/PutObjectRequest.h>
+#include <aws/core/http/standard/StandardHttpResponse.h>
+#include <aws/core/http/standard/StandardHttpRequest.h>
+#include <aws/core/utils/stream/PreallocatedStreamBuf.h>
+#include <aws/core/client/CoreErrors.h>
+#include <aws/core/client/AsyncCallerContext.h>
+#include <aws/core/utils/threading/Semaphore.h>
+#include <aws/common/error.h>
+#include <aws/s3/s3.h>
+#include <aws/testing/MemoryTesting.h>
+
+using namespace Aws;
+using namespace Aws::S3Crt;
+using namespace Aws::S3Crt::Model;
+using namespace Aws::Client;
+
+const char* ALLOCATION_TAG = "S3CrtTest";
+
+
+class TestS3CrtClient : public S3CrtClient {
+public:
+    using S3CrtClient::S3CrtClient;
+};
+
+class S3CrtUnitTest : public ::testing::Test
+{
+protected:
+    void SetUp() override {}
+    void TearDown() override {}
+};
+
+TEST_F(S3CrtUnitTest, Test200WithErrorXml)
+{
+}