From 0a3224345d7a9b64dcfe46fdad88e3757827394a Mon Sep 17 00:00:00 2001 From: hanwenli Date: Mon, 18 May 2026 13:39:45 -0700 Subject: [PATCH] Change validation of automatic backup retention days of FSx Lustre to 90 This code change aligns with FSx doc https://docs.aws.amazon.com/fsx/latest/APIReference/API_LustreFileSystemConfiguration.html and ParallelCluster doc https://docs.aws.amazon.com/parallelcluster/latest/ug/SharedStorage-v3.html#yaml-SharedStorage-FsxLustreSettings-AutomaticBackupRetentionDays --- cli/src/pcluster/schemas/cluster_schema.py | 2 +- cli/tests/pcluster/schemas/test_schema_validators.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cli/src/pcluster/schemas/cluster_schema.py b/cli/src/pcluster/schemas/cluster_schema.py index 601535ec8b..da6c8a80c7 100644 --- a/cli/src/pcluster/schemas/cluster_schema.py +++ b/cli/src/pcluster/schemas/cluster_schema.py @@ -413,7 +413,7 @@ class FsxLustreSettingsSchema(BaseSchema): metadata={"update_policy": UpdatePolicy.SUPPORTED}, ) automatic_backup_retention_days = fields.Int( - validate=validate.Range(min=0, max=35), metadata={"update_policy": UpdatePolicy.SUPPORTED} + validate=validate.Range(min=0, max=90), metadata={"update_policy": UpdatePolicy.SUPPORTED} ) copy_tags_to_backups = fields.Bool(metadata={"update_policy": UpdatePolicy.UNSUPPORTED}) daily_automatic_backup_start_time = fields.Str( diff --git a/cli/tests/pcluster/schemas/test_schema_validators.py b/cli/tests/pcluster/schemas/test_schema_validators.py index 6f8f41abc9..69b912141f 100644 --- a/cli/tests/pcluster/schemas/test_schema_validators.py +++ b/cli/tests/pcluster/schemas/test_schema_validators.py @@ -457,7 +457,7 @@ def test_efs_throughput_mode_provisioned_throughput_validator(section_dict, expe ({"AutomaticBackupRetentionDays": ""}, "Not a valid integer"), ({"AutomaticBackupRetentionDays": 0}, None), ({"AutomaticBackupRetentionDays": 35}, None), - ({"AutomaticBackupRetentionDays": 36}, "Must be.*less than or equal to 35"), + ({"AutomaticBackupRetentionDays": 91}, "Must be.*less than or equal to 90"), ({"CopyTagsToBackups": ""}, "Not a valid boolean"), ({"CopyTagsToBackups": "NONE"}, "Not a valid boolean"), ({"CopyTagsToBackups": True}, None),