Skip to content

Commit 3acdb55

Browse files
committed
Remove ubuntu2004 from tested OSs for tests that use DCV with ARM architecture
1 parent f3f511f commit 3acdb55

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

cli/src/pcluster/cli/commands/dcv_util.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@
99
# OR CONDITIONS OF ANY KIND, express or implied. See the License for the specific language governing permissions and
1010
# limitations under the License.
1111

12-
from pcluster.constants import SUPPORTED_OSES, UNSUPPORTED_OSES_FOR_DCV
12+
from pcluster.constants import SUPPORTED_OSES, UNSUPPORTED_ARM_OSES_FOR_DCV, UNSUPPORTED_OSES_FOR_DCV
1313

1414

1515
def get_supported_dcv_os(architecture):
1616
"""Return a list of all the operating system supported by DCV."""
1717
architectures_dict = {
1818
"x86_64": [os for os in SUPPORTED_OSES if os not in UNSUPPORTED_OSES_FOR_DCV],
19-
"arm64": ["alinux2", "rhel8", "rocky8", "rhel9", "rocky9"],
19+
"arm64": [os for os in SUPPORTED_OSES if os not in UNSUPPORTED_OSES_FOR_DCV + UNSUPPORTED_ARM_OSES_FOR_DCV],
2020
}
2121
return architectures_dict.get(architecture, [])

cli/src/pcluster/constants.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
SUPPORTED_OSES_FOR_SCHEDULER = {"slurm": SUPPORTED_OSES, "awsbatch": ["alinux2", "alinux2023"]}
2828
UNSUPPORTED_OSES_FOR_MICRO_NANO = ["ubuntu2004", "ubuntu2204", "rhel8", "rocky8", "rhel9", "rocky9"]
2929
UNSUPPORTED_OSES_FOR_DCV = ["alinux2023"]
30+
UNSUPPORTED_ARM_OSES_FOR_DCV = ["ubuntu2004"]
3031
DELETE_POLICY = "Delete"
3132
RETAIN_POLICY = "Retain"
3233
DELETION_POLICIES = [DELETE_POLICY, RETAIN_POLICY]

tests/integration-tests/configs/develop.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ test-suites:
361361
# S3 bucket belonging to the same region and S3 VPC Endpoints only work within the region.
362362
- regions: ["us-east-1"]
363363
instances: {{ common.INSTANCES_DEFAULT_ARM }}
364-
oss: [{{ OS_ARM_3 }}]
364+
oss: [{{ DCV_OS_ARM_3 }}]
365365
schedulers: ["slurm"]
366366
- regions: ["cn-north-1"]
367367
instances: {{ common.INSTANCES_DEFAULT_X86 }}

tests/integration-tests/framework/tests_configuration/config_renderer.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
from jinja2.sandbox import SandboxedEnvironment
2020
from utils import InstanceTypesData
2121

22-
from pcluster.constants import SUPPORTED_OSES, UNSUPPORTED_OSES_FOR_DCV
22+
from pcluster.constants import SUPPORTED_OSES, UNSUPPORTED_ARM_OSES_FOR_DCV, UNSUPPORTED_OSES_FOR_DCV
2323

2424

2525
def _get_os_parameters(config=None, args=None):
@@ -39,8 +39,11 @@ def _get_os_parameters(config=None, args=None):
3939

4040
# DCV doesn't support AL2023. Therefore, the following logic makes sure the DCV jinja parameter is not AL2023
4141
dcv_supported_oses = [os for os in SUPPORTED_OSES if os not in UNSUPPORTED_OSES_FOR_DCV]
42+
dcv_supported_arm_oses = [
43+
os for os in SUPPORTED_OSES if os not in UNSUPPORTED_OSES_FOR_DCV + UNSUPPORTED_ARM_OSES_FOR_DCV
44+
]
4245
dcv_available_amis_oss_x86 = list(set(dcv_supported_oses) & set(available_amis_oss_x86))
43-
dcv_available_amis_oss_arm = list(set(dcv_supported_oses) & set(available_amis_oss_arm))
46+
dcv_available_amis_oss_arm = list(set(dcv_supported_arm_oses) & set(available_amis_oss_arm))
4447
for index in range(len(dcv_supported_oses)):
4548
result[f"DCV_OS_X86_{index}"] = dcv_available_amis_oss_x86[
4649
(today_number + index) % len(dcv_available_amis_oss_x86)

0 commit comments

Comments
 (0)