-
Notifications
You must be signed in to change notification settings - Fork 150
Test2 #2781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Test2 #2781
Conversation
…to xaes-256-gcm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
| #define NUM_NID 999 | ||
| #define NUM_NID 1001 | ||
|
|
||
| static const uint8_t kObjectData[] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: unknown type name 'uint8_t' [clang-diagnostic-error]
static const uint8_t kObjectData[] = {
^| 0x31, | ||
| }; | ||
|
|
||
| static const ASN1_OBJECT kObjects[NUM_NID] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: unknown type name 'ASN1_OBJECT' [clang-diagnostic-error]
static const ASN1_OBJECT kObjects[NUM_NID] = {
^
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2781 +/- ##
==========================================
+ Coverage 78.52% 78.73% +0.21%
==========================================
Files 680 680
Lines 115362 115539 +177
Branches 16329 16350 +21
==========================================
+ Hits 90587 90971 +384
+ Misses 23979 23767 -212
- Partials 796 801 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Issues:
Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2
Description of changes:
Describe AWS-LC’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.