Fix nullptr exception with invalid credentials

hefroy · hefroy · commit af6c0ff64a85 · 2023-12-20T15:55:50.000+01:00
diff --git a/src/AwsIotChannel.cpp b/src/AwsIotChannel.cpp
@@ -96,7 +96,7 @@ AwsIotChannel::subscribe()
                 {
                     TraceModule::get().incrementAtomicVariable( TraceAtomicVariable::SUBSCRIBE_ERROR );
                     // coverity[cert_str51_cpp_violation] - pointer comes from std::string, which can't be null
-                    auto reasonString = std::string( subAckPacket->getReasonString()->c_str() != nullptr
+                    auto reasonString = std::string( subAckPacket->getReasonString().has_value()
                                                          ? subAckPacket->getReasonString()->c_str()
                                                          : "Unknown reason" );
                     FWE_LOG_ERROR( "Server rejected subscription to topic " + mTopicName + ". Reason code " +

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ AwsIotChannel::subscribe()`
`96`	`96`	`{`
`97`	`97`	`TraceModule::get().incrementAtomicVariable( TraceAtomicVariable::SUBSCRIBE_ERROR );`
`98`	`98`	`// coverity[cert_str51_cpp_violation] - pointer comes from std::string, which can't be null`
`99`		`- auto reasonString = std::string( subAckPacket->getReasonString()->c_str() != nullptr`
	`99`	`+ auto reasonString = std::string( subAckPacket->getReasonString().has_value()`
`100`	`100`	`? subAckPacket->getReasonString()->c_str()`
`101`	`101`	`: "Unknown reason" );`
`102`	`102`	`FWE_LOG_ERROR( "Server rejected subscription to topic " + mTopicName + ". Reason code " +`