Closes socket in client destructor to avoid FD leak.

Author: xiazhvera

AWSIoTPythonSDK/core/protocol/paho/client.py

@@ -511,7 +511,8 @@ def __init__(self, client_id="", clean_session=True, userdata=None, protocol=MQT
         self._alpn_protocols = None
 
     def __del__(self):
-        pass
+        # Closes socket in client destructor to avoid FD leak.
+        self._reset_sockets()
 
 
     def setBackoffTiming(self, srcBaseReconnectTimeSecond, srcMaximumReconnectTimeSecond, srcMinimumConnectTimeSecond):
@@ -543,7 +544,8 @@ def config_alpn_protocols(self, alpn_protocols):
         """
         self._alpn_protocols = alpn_protocols
 
-    def reinitialise(self, client_id="", clean_session=True, userdata=None):
+    # Closes socket in client destructor to avoid FD leak.
+    def _reset_sockets(self):
         if self._ssl:
             self._ssl.close()
             self._ssl = None
@@ -558,6 +560,9 @@ def reinitialise(self, client_id="", clean_session=True, userdata=None):
             self._sockpairW.close()
             self._sockpairW = None
 
+    # Closes socket in client destructor to avoid FD leak.
+    def reinitialise(self, client_id="", clean_session=True, userdata=None):
+        self._reset_sockets()
         self.__init__(client_id, clean_session, userdata)
 
     def tls_set(self, ca_certs, certfile=None, keyfile=None, cert_reqs=cert_reqs, tls_version=tls_version, ciphers=None):