Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Library Supports Regex Search #167

Open
1 of 2 tasks
anish-kunduru opened this issue Oct 4, 2023 · 5 comments
Open
1 of 2 tasks

Asset Library Supports Regex Search #167

anish-kunduru opened this issue Oct 4, 2023 · 5 comments

Comments

@anish-kunduru
Copy link
Contributor

Aws Connected Device Framework Affected Module(s):

I'm submitting a ...

  • bug report
  • feature request

Description:

With the introduction of TinkerPop 3.6.x, it is now possible to search via regex, which should make it much easier to find matches. The request is to support this functionality by adding updating the minimum cluster version to 1.2.1.0.R2, which includes TinkerPop 3.6 and updating the relevant CDF code to take regex input as an argument.

Current behavior:

CDF supports the ability to search, but doesn't support regex capability.

Expected behavior:

Steps to reproduce:

Additional Information:
Currently WIP on a branch in my fork.

@canavandl
Copy link
Contributor

Hi @anish-kunduru - Do you mind opening a PR of your WIP branch and we can discuss what's required to finish it/get it merged?

@joysl
Copy link
Contributor

joysl commented Oct 23, 2023

Hi @canavandl ,
In order for regex to work NeptuneDB engine version has to be 1.2.1.0: https://docs.aws.amazon.com/neptune/latest/userguide/engine-releases-1.2.1.0.html
However if we deploy CDF with Asset Library the Neptune version deployed is 1.2.0.2
I'm working on a feature, where version can be specifies in addition to the instance family.
CC: @jaychung-aws
#170

@joysl
Copy link
Contributor

joysl commented Nov 3, 2023

PR is now ready: #179
CC: @anish-kunduru @jaychung-aws @canavandl

@joysl
Copy link
Contributor

joysl commented Nov 8, 2023

Verified that this works E2E with a minor change on gremlin version[updated] just make sure #179 is merged first

CC: @jaychung-aws thanks for figuring out the issue

@anish-kunduru
Copy link
Contributor Author

@canavandl I was out on vacation, so @joysl picked this up for me.

Does it make sense for us to combine Joyson's PR into this feature and merge both at the same time? We'll have to rebase to pull in the latest changes from master and I'd like to avoid doing that multiple times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants