-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset Library Supports Regex Search #167
Comments
Hi @anish-kunduru - Do you mind opening a PR of your WIP branch and we can discuss what's required to finish it/get it merged? |
Hi @canavandl , |
PR is now ready: #179 |
Verified that this works E2E with a minor change on gremlin version[updated] just make sure #179 is merged first CC: @jaychung-aws thanks for figuring out the issue |
@canavandl I was out on vacation, so @joysl picked this up for me. Does it make sense for us to combine Joyson's PR into this feature and merge both at the same time? We'll have to rebase to pull in the latest changes from master and I'd like to avoid doing that multiple times. |
Aws Connected Device Framework Affected Module(s):
I'm submitting a ...
Description:
With the introduction of TinkerPop 3.6.x, it is now possible to search via regex, which should make it much easier to find matches. The request is to support this functionality by adding updating the minimum cluster version to 1.2.1.0.R2, which includes TinkerPop 3.6 and updating the relevant CDF code to take regex input as an argument.
Current behavior:
CDF supports the ability to search, but doesn't support regex capability.
Expected behavior:
Steps to reproduce:
Additional Information:
Currently WIP on a branch in my fork.
The text was updated successfully, but these errors were encountered: