-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(imagebuilder-alpha): add support for Distribution Configuration Construct #36005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1de77fb to
cfde029
Compare
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
cfde029 to
9a9c664
Compare
Pull request has been modified.
1fba748 to
5d3ff75
Compare
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Show resolved
Hide resolved
Pull request has been modified.
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Show resolved
Hide resolved
| public addAmiDistributions(...amiDistributions: AmiDistribution[]): void { | ||
| amiDistributions.forEach((amiDistribution) => { | ||
| const region = amiDistribution.region ?? cdk.Stack.of(this).region; | ||
| if (!cdk.Token.isUnresolved(region) && this.amiDistributionsByRegion[region]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this restriction apply to a combination of AmiDistributionConfiguration and ContainerDistributionConfiguration being in same region well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct - each Distribution object must be unique to a region
packages/@aws-cdk/aws-imagebuilder-alpha/lib/distribution-configuration.ts
Outdated
Show resolved
Hide resolved
722fa15 to
bb3a318
Compare
Pull request has been modified.
… Distribution Configuration
bb3a318 to
5f7848e
Compare
Issue
aws/aws-cdk-rfcs#789
Reason for this change
This change adds a new alpha module for EC2 Image Builder L2 Constructs (
@aws-cdk/aws-imagebuilder-alpha), as outlined in aws/aws-cdk-rfcs#789. This PR specifically implements theDistributionConfigurationconstruct.Description of changes
This change implements the
DistributionConfigurationconstruct, which is a higher-level construct ofCfnDistributionConfiguration.Example
Describe any new or updated permissions being added
N/A - new L2 construct in alpha module
Description of how you validated changes
Validated with unit tests and integration tests. Manually verified generated CFN templates as well.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license