Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws_ecs): Daemon Scheduling Strategy on ECS Service #32538

Open
1 task
driverpt opened this issue Dec 16, 2024 · 3 comments · May be fixed by #32630
Open
1 task

(aws_ecs): Daemon Scheduling Strategy on ECS Service #32538

driverpt opened this issue Dec 16, 2024 · 3 comments · May be fixed by #32630
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@driverpt
Copy link

Describe the bug

As title says

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

2.173.1

Expected Behavior

To be able to set Daemon Scheduling Strategy

Current Behavior

Not able to set Daemon Scheduling Strategy

Reproduction Steps

Create any deriving type of IService

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.173.1 (build 4eac959)

Framework Version

No response

Node.js Version

22

OS

MacOS

Language

TypeScript

Language Version

~5.5.3

Other information

No response

@driverpt driverpt added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 16, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Dec 16, 2024
@khushail khushail added needs-reproduction This issue needs reproduction. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Dec 16, 2024
@khushail khushail self-assigned this Dec 16, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-reproduction This issue needs reproduction. labels Dec 16, 2024
@khushail
Copy link
Contributor

Hi @driverpt , thanks for reaching out. Not really sure how you are doing it but I found out this has been mentioned in AWS DOCS as well as in this sage post.

Tasks using the Fargate launch type or the CODE_DEPLOY or EXTERNAL deployment controller types don't support the daemon scheduling strategy.

However it would be great if you could share minimum self contained issue reproduction code.
Thanks.

@khushail khushail added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Dec 16, 2024
@driverpt
Copy link
Author

driverpt commented Dec 17, 2024

Hello,

I'm trying to deploy on an EXTERNAL ECS Anywhere instance (Not Deployment Controller), but with ECS Deployment Controller. For that to work I had to do the following

(<CfnService>service.node.defaultChild).schedulingStrategy = "DAEMON";

Would be great if you added support for this property in the L2 Construct

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Dec 17, 2024
@khushail
Copy link
Contributor

khushail commented Dec 18, 2024

Hi @driverpt , thanks for responding back. Looks like this issue is more of a feature request , so I would be converting this to FR.

Searching in the Cloduformation docs, I assume this is what you are trying to request regarding the ECS Anywhere scheduling strategy -

  1. Scheduling strategy support in Cloudformation - https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ecs-service.html#cfn-ecs-service-schedulingstrategy
  2. Interface ExternalServiceProps does not support this property hence one has to use the L1 construct for this.

Code reference -https://github.com/aws/aws-cdk/blob/f8e62073484d22291656b3e9ae27f22cc5c020cf/packages/aws-cdk-lib/aws-ecs/lib/external/external-service.ts#L15C18-L15C38

Marking this as P2 as there is a workaround to use [L1 construct].(https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ecs.CfnService.html#schedulingstrategy) Contributions from community are welcome.

Hope that makes sense and is helpful. Let me know if something is misinterpreted.

@khushail khushail added feature-request A feature should be added or improved. effort/small Small work item – less than a day of effort and removed bug This issue is a bug. labels Dec 18, 2024
@khushail khushail removed their assignment Dec 18, 2024
@khushail khushail changed the title (aws_ecs): Not able to set Daemon Scheduling Strategy on ECS Service (aws_ecs): Daemon Scheduling Strategy on ECS Service Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants