-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(step-functions): (add keyPath in item reader) #32602
Comments
Hi @Nicolas-SB , thanks for reaching out. I see that in the AWS Stepfunction README file, it looks like the JSON Path is supported for the parameter https://github.com/aws/aws-cdk/blob/v2.173.2/packages/aws-cdk-lib/aws-stepfunctions/README.md Hope this is what you are looking for. Let me know if your ask is different. |
@Nicolas-SB , I see that you got it working in Typescript so it should work in python as well. I will try to repro this in python and share the code. However I agree that there should have been clear explanation reg. Key JSONPATH. So marking it as P3 which means community contributions are welcome in this regard. |
Describe the feature
Analogous to the new bucketNamePath parameter introduced in #31619 I expected to find a keyPath parameter when creating a item reader.
If the already existing "key" parameter is supposed to implicitly support JsonPath, then the naming and docstring of the parameter does not clearly express that.
Use Case
I get an input event containing the dynamically generated key of the manifest file and want to reference it. The constructor of the class, in my case S3JsonItemReader, is vague about how to achieve this. In the AWS console for step functions I can just give it a JsonPath, the CDK constructor tells me to give it a concrete key.
Proposed Solution
Either add a new parameter key_path analogous to bucket_name_path or update the docstring of parameter key to point out clearly that JsonPath is supported.
Other Information
On a side-note, the docstring of bucket and bucket_name_path tells me the default is "S3 bucket will be determined from" - I do not quite understand what this is supposed to tell me
Acknowledgements
CDK version used
2.173.2
Environment details (OS name and version, etc.)
macOS Sequoia 15.2
The text was updated successfully, but these errors were encountered: