Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eks: Add EKS Auto Mode support to Cluster L2 construct #32364

Open
2 tasks
zjaco13 opened this issue Dec 2, 2024 · 7 comments · May be fixed by #32601
Open
2 tasks

eks: Add EKS Auto Mode support to Cluster L2 construct #32364

zjaco13 opened this issue Dec 2, 2024 · 7 comments · May be fixed by #32601
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@zjaco13
Copy link

zjaco13 commented Dec 2, 2024

Describe the feature

AWS Announced EKS Auto Mode on Dec 1st, enabling customers to fully automate cluster management for compute, storage, and networking. The CloudFormation changes for EKS Auto Mode enablement are adding a ComputeConfig field in the Cluster resource. Supporting this field would enable customers to easily create EKS Auto Mode or enable it on existing clusters.

Use Case

Create/Enable EKS Auto Mode on new or existing clusters for fully automated cluster management.

Proposed Solution

Add support for the ComputeConfig Field to the EKS Cluster L2 construct

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.171.1

Environment details (OS name and version, etc.)

mac OS Sonoma 14.7.1

@zjaco13 zjaco13 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 2, 2024
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Dec 2, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Dec 3, 2024
@khushail khushail self-assigned this Dec 3, 2024
@khushail
Copy link
Contributor

khushail commented Dec 4, 2024

Hi @zjaco13 , thanks for staying on top of the AWS cloudformation updates for EKS. Looks like its supported by cloudformation, so should be feasible to have support by CDK as well. Contributions are welcome.

@khushail khushail added effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Dec 4, 2024
@khushail khushail removed their assignment Dec 4, 2024
@Issacwww
Copy link

Issacwww commented Dec 6, 2024

@khushail
Is there any plan for L1 construct support? not seeing the ComputeConfig been added here
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_eks.CfnCluster.html

@khushail
Copy link
Contributor

khushail commented Dec 6, 2024

@Issacwww , cloudformation docs mention about supporting this property-
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-eks-cluster-computeconfig.html

and in the resource specification doc, you can also see this as mentioned -

https://d1uauaxba7bl26.cloudfront.net/latest/gzip/CloudFormationResourceSpecification.json

Screenshot 2024-12-06 at 11 48 55 AM

Hopefully docs would reflect the latest changes in next cadence. Hope that helps!

@Issacwww
Copy link

Issacwww commented Dec 7, 2024

Ah, Thanks for confirming, @khushail, makes sense if just doc delay, I will try the latest cdk version

@caleblloyd
Copy link

Is it possible to use an escape hatch to modify the L1 construct from the L2 construct for an EKS Cluster?

I am trying:

const cfnCluster = cluster.node.defaultChild as eks.CfnCluster
cfnCluster.computeConfig = {
  enabled: true,
  nodePools: ["system"],
  nodeRoleArn: nodeRole.roleArn,
}

But that is not working, maybe due to #18620. Is the eks.CfnCluster available under a different node than cluster.node.defaultChild?

@otterley
Copy link
Contributor

Requires JavaScript SDK >= 3.703.0 and latest CloudFormation schema

@Issacwww Issacwww linked a pull request Dec 20, 2024 that will close this issue
1 task
@github-actions github-actions bot added p1 and removed p2 labels Dec 22, 2024
Copy link

This issue has received a significant amount of attention so we are automatically upgrading its priority. A member of the community will see the re-prioritization and provide an update on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants