feat(ecs): add tls property to a ServiceConnectService
#32605
Conversation
github-actions
bot
added
repeat-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
ren-yamanashi
changed the title
tls property to a ServiceConnectServicetls property to a ServiceConnectService
ren-yamanashi
changed the title
tls property to a ServiceConnectServicetls property to a ServiceConnectService
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32605 +/- ##
=======================================
Coverage 80.49% 80.49%
=======================================
Files 106 106
Lines 6957 6957
Branches 1289 1289
=======================================
Hits 5600 5600
Misses 1178 1178
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| const certificateAuthority = acm.CertificateAuthority.fromCertificateAuthorityArn(stack, 'CA', | ||
| 'arn:aws:acm-pca:us-east-1:123456789012:certificate-authority/123456789012', | ||
| ); |
There was a problem hiding this comment.
When I tested integ in the local environment, I specified the ARN value of the PCA ARN used in my account.
However, since that ARN cannot be included in the commit, a dummy value is now specified.
(Originally, it is considered appropriate to specify it as an environment variable, but the key name is unknown, so I am currently requesting an update to the docs.)
see: #32621
ren-yamanashi
force-pushed
the
32583-feat-support-tls-on-service-connect-service
branch
from
cc3f0ca to
6f8bf3d
Compare
…-support-tls-on-service-connect-service
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #32583
Reason for this change
ServiceConnectService in ECS did not support the
tlsproperty.Description of changes
tlsproperty to ServiceConnectService(interface) in ECS(BaseService)enableServiceConnectmethodDescription of how you validated changes
Added both unit and integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license