From 4039c5a2d9fbadcd7501e9cc9cdbf3022b22cc77 Mon Sep 17 00:00:00 2001 From: joyc-bq <95259163+joyc-bq@users.noreply.github.com> Date: Thu, 2 Jan 2025 15:12:43 -0800 Subject: [PATCH] fix: secrets manager logging (#360) --- common/lib/authentication/aws_secrets_manager_plugin.ts | 2 +- tests/unit/aws_secrets_manager_plugin.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/lib/authentication/aws_secrets_manager_plugin.ts b/common/lib/authentication/aws_secrets_manager_plugin.ts index 6962211b..108fad97 100644 --- a/common/lib/authentication/aws_secrets_manager_plugin.ts +++ b/common/lib/authentication/aws_secrets_manager_plugin.ts @@ -53,7 +53,7 @@ export class AwsSecretsManagerPlugin extends AbstractConnectionPlugin { const config: SecretsManagerClientConfig = {}; if (!secretId) { - throw new AwsWrapperError(Messages.get("AwsSecretsManagerConnectionPlugin.missingRequiredConfigParameter"), WrapperProperties.SECRET_ID.name); + throw new AwsWrapperError(Messages.get("AwsSecretsManagerConnectionPlugin.missingRequiredConfigParameter", WrapperProperties.SECRET_ID.name)); } if (!region) { diff --git a/tests/unit/aws_secrets_manager_plugin.test.ts b/tests/unit/aws_secrets_manager_plugin.test.ts index 22e8c9eb..35f73535 100644 --- a/tests/unit/aws_secrets_manager_plugin.test.ts +++ b/tests/unit/aws_secrets_manager_plugin.test.ts @@ -120,7 +120,7 @@ describe("testSecretsManager", () => { it("missing required parameters", () => { expect(async () => { await new AwsSecretsManagerPlugin(mockPluginService, new Map()).connect(TEST_HOSTINFO, TEST_PROPS, true, mockConnectFunction); - }).rejects.toStrictEqual(new AwsWrapperError(Messages.get("AwsSecretsManagerConnectionPlugin.missingRequiredConfigParameter"))); + }).rejects.toStrictEqual(new AwsWrapperError(Messages.get("AwsSecretsManagerConnectionPlugin.missingRequiredConfigParameter", "secretId"))); }); // The plugin will attempt to open a connection with a cached secret, but it will fail with a unhandled error.