Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create integration test for renaming Windows system metric #253

Open
SaxyPandaBear opened this issue Jun 16, 2023 · 0 comments
Open

Create integration test for renaming Windows system metric #253

SaxyPandaBear opened this issue Jun 16, 2023 · 0 comments

Comments

@SaxyPandaBear
Copy link
Contributor

The logic for deriving the default name for Windows metrics differs from Unix. Rather than using a _ to separate, on Windows, the agent uses to separate. For example, instead of cpu_time_active, for the CPU plugin, the agent would hypothetically decorate the metric as cpu time_active. A bug was identified where we weren't properly renaming the metric when the prefix is omitted in the rename configuration, e.g.: "rename": "time_active" on Linux. The integration test that checks this on Linux is failing in our staging repo. There is nothing that would have caught this for Windows, as of right now. We need to add an integration test for that edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant