Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue Website fails to build #352

Closed
6 tasks done
giusedroid opened this issue Nov 2, 2022 · 4 comments
Closed
6 tasks done

Vue Website fails to build #352

giusedroid opened this issue Nov 2, 2022 · 4 comments
Labels

Comments

@giusedroid
Copy link

giusedroid commented Nov 2, 2022

Describe the bug

npm build of ./source/website fails with the following error

$: npm run build

[email protected] build
vue-cli-service build


⠧  Building for production...

 ERROR  Failed to compile with 1 error                                                                                                                                                                                                                

This dependency was not found:

* @/../node_modules/videojs-hotkeys/build/videojs.hotkeys.min.js in ./node_modules/cache-loader/dist/cjs.js??ref--12-0!./node_modules/thread-loader/dist/cjs.js!./node_modules/babel-loader/lib!./node_modules/cache-loader/dist/cjs.js??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./src/components/VideoPlayer.vue?vue&type=script&lang=js&

To install it, you can run: npm install --save @/../node_modules/videojs-hotkeys/build/videojs.hotkeys.min.js
 ERROR  Build failed with errors.

To Reproduce

cd ./source/website
npm i
npm run build

Expected behavior

it actually builds

Please complete the following information about the solution:

  • Version: v2.0.0

  • Region: not applicable, the bug is with the front-end build

  • Was the solution modified from the version published on this repository? no

  • If the answer to the previous question was yes, are the changes available on GitHub?

  • Have you checked your [service quotas] (https://docs.aws.amazon.com/general/latest/gr/aws_service_limits.html) for the sevices this solution uses? not applicable

  • Were there any errors in the CloudWatch Logs? not applicable

Screenshots

If applicable, add screenshots to help explain your problem (please DO NOT include sensitive information).

Additional context

Tested build on Node 16.13.0 on both macOS and Cloud9 AmazonLinux 2.0

@giusedroid
Copy link
Author

raised a PR. Can you please review it?
#353

@cassneal
Copy link
Member

cassneal commented Nov 5, 2022

We will discuss this ticket and now PR in our next backlog review meeting.

@cassneal
Copy link
Member

cassneal commented Nov 7, 2022

Thanks for the PR. We reviewed this ticket and have added a task for the PR review and potential merge into the backlog for the next update we do this for solution. Date TBD.

@raulmlamzn
Copy link
Member

Closing this issue since solution was upgraded to Vue.js v3 in 2.1.3:
https://github.com/aws-solutions/content-localization-on-aws/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants