Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

Move functions to Arm64 #184

Open
nmoutschen opened this issue Oct 29, 2021 · 3 comments
Open

Move functions to Arm64 #184

nmoutschen opened this issue Oct 29, 2021 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nmoutschen
Copy link
Contributor

Make all the Lambda functions use Arm64 instead of x86_64.

@nilskelleter
Copy link
Contributor

Hi Nicolas,

maybe I can support with this task.

Do you already know that it is "only" necessary to add the architectures parameter to the SAM templates or do you expect any issues with some dependencies which have no ARM64 support?

Regards

Nils

@nmoutschen
Copy link
Contributor Author

Hey @nilskelleter !

Thanks a lot for the help here! In theory, it should work. I've been building and deploy this project from both Linux and MacOS without issue, so I'm assuming there are no compilation is needed. That said, some libraries might package their own binaries which might not have Arm64 support.

@nmoutschen nmoutschen added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 1, 2021
nilskelleter added a commit to nilskelleter/aws-serverless-ecommerce-platform that referenced this issue Nov 3, 2021
…y, delivery-pricing, orders, payment, platform, products, users sand warehouse service.
@nilskelleter
Copy link
Contributor

In my PR only the services delivery, delivery-pricing, orders, payment, platform, products, users sand warehouse service are covered at the moment.

The payment-3p is not covered because I shortly checked the @aws-cdk/aws-sam documentation (https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-sam.CfnFunction.html) and it looks like that the CfnFunction class currently does not support Arm64. But I have no experience with CDK yet, so maybe there is another solution.

Also the CI/CD pipeline is not changed. Maybe the image of the BuildProject should be changed from aws/codebuild/standard:3.0 to aws/codebuild/amazonlinux2-aarch64-standard:2.0. But I don't oversee the consequence of this change at the moment for the complete pipeline.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants