Skip to content

Commit 583f920

Browse files
patch dependancies (#78)
* Move Name to properties section * Fix cfn-nag FAIL F3 IAM role should not allow * action on its permissions policy * Add settings.js to outputs * Update react-scripts to 5.x * Update libraries to the latest * Encrypt bucket * Add unit tests for cfn * Fix the branch name * Update src/cfn/template.yaml Co-authored-by: Matteo Figus <[email protected]>
1 parent 30a9904 commit 583f920

File tree

11 files changed

+46563
-51006
lines changed

11 files changed

+46563
-51006
lines changed

.github/workflows/publish.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ jobs:
4040
uses: actions/setup-python@v1
4141
with:
4242
python-version: 3.7
43-
- name: Set up Nodejs 12
43+
- name: Set up Nodejs 16
4444
uses: actions/setup-node@v1
4545
with:
46-
node-version: 14
46+
node-version: 16
4747
- name: Install node dependencies
4848
run: npm i
4949
- name: Install python dependencies

.github/workflows/release.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ jobs:
2424
uses: actions/setup-python@v1
2525
with:
2626
python-version: 3.7
27-
- name: Set up Nodejs 12
27+
- name: Set up Nodejs 16
2828
uses: actions/setup-node@v1
2929
with:
30-
node-version: 14
30+
node-version: 16
3131
- name: Install dependencies
3232
run: npm i
3333
- name: Install python dependencies

.github/workflows/unit-tests.yaml

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
name: Unit Tests
2+
on:
3+
push:
4+
branches:
5+
- master
6+
pull_request:
7+
types:
8+
- opened
9+
- edited
10+
- synchronize
11+
jobs:
12+
unit_tests:
13+
name: Unit tests
14+
runs-on: ubuntu-latest
15+
steps:
16+
- uses: actions/checkout@v2
17+
18+
# Cache
19+
- uses: actions/cache@v1
20+
with:
21+
path: ~/.cache/pip
22+
key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
23+
restore-keys: |
24+
25+
# Setup
26+
- name: Set up Python
27+
uses: actions/setup-python@v2
28+
with:
29+
python-version: '3.10' # have to use quotes due to 0 being removed
30+
- name: Install python packages
31+
run: pip install -Ur requirements.txt
32+
- name: Set up Ruby
33+
uses: ruby/setup-ruby@v1
34+
with:
35+
ruby-version: 3.1
36+
- name: Install Ruby gems
37+
run: gem install cfn-nag
38+
39+
# Run Tests
40+
- name: CloudFormation lint test
41+
run: cfn-lint src/cfn/**/*.yaml
42+
- name: CloudFormation nag test
43+
run: cfn_nag_scan --input-path src/cfn

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ We may ask you to sign a [Contributor License Agreement (CLA)](http://en.wikiped
7878

7979
The following applications are required to contribute:
8080

81-
* Node.js >=v8
81+
* Node.js >=16.x and npm>=8.x
8282
* AWS CLI
8383

8484
To start, run `npm install`.

0 commit comments

Comments
 (0)