-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nucleus connectivity validation #1587
Open
tiancishen
wants to merge
2
commits into
main
Choose a base branch
from
resilientNucleusConfig
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiancishen
force-pushed
the
resilientNucleusConfig
branch
2 times, most recently
from
March 13, 2024 01:19
60934b7
to
5446985
Compare
MikeDombo
reviewed
Mar 13, 2024
src/main/java/com/aws/greengrass/deployment/ThingGroupHelper.java
Outdated
Show resolved
Hide resolved
alter-mage
reviewed
Mar 13, 2024
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
alter-mage
reviewed
Mar 13, 2024
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
alter-mage
reviewed
Mar 14, 2024
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
alter-mage
reviewed
Mar 14, 2024
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
alter-mage
reviewed
Mar 14, 2024
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
alter-mage
reviewed
Mar 14, 2024
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
alter-mage
reviewed
Mar 14, 2024
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
alter-mage
reviewed
Mar 14, 2024
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
alter-mage
reviewed
Mar 14, 2024
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
alter-mage
reviewed
Mar 14, 2024
MikeDombo
reviewed
Mar 14, 2024
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
MikeDombo
reviewed
Mar 14, 2024
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
MikeDombo
reviewed
Mar 14, 2024
src/main/java/com/aws/greengrass/deployment/ThingGroupHelper.java
Outdated
Show resolved
Hide resolved
MikeDombo
reviewed
Mar 14, 2024
src/main/java/com/aws/greengrass/deployment/activator/DeploymentActivator.java
Outdated
Show resolved
Hide resolved
tiancishen
force-pushed
the
resilientNucleusConfig
branch
from
March 18, 2024 17:41
5446985
to
813116b
Compare
MikeDombo
reviewed
Mar 18, 2024
src/main/java/com/aws/greengrass/deployment/ThingGroupHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
tiancishen
force-pushed
the
resilientNucleusConfig
branch
from
March 19, 2024 17:40
813116b
to
4de2fb2
Compare
MikeDombo
reviewed
Mar 19, 2024
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
tiancishen
force-pushed
the
resilientNucleusConfig
branch
3 times, most recently
from
March 19, 2024 21:42
8f9f232
to
01b13f1
Compare
MikeDombo
reviewed
Mar 19, 2024
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
tiancishen
force-pushed
the
resilientNucleusConfig
branch
from
March 19, 2024 21:58
01b13f1
to
027aacf
Compare
MikeDombo
reviewed
Mar 19, 2024
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
junfuchen99
reviewed
Mar 19, 2024
MikeDombo
reviewed
Mar 19, 2024
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
alter-mage
reviewed
May 9, 2024
src/main/java/com/aws/greengrass/deployment/ConnectivityValidator.java
Outdated
Show resolved
Hide resolved
alter-mage
reviewed
May 9, 2024
tiancishen
force-pushed
the
resilientNucleusConfig
branch
4 times, most recently
from
May 9, 2024 23:40
6a50d3d
to
f32b2d5
Compare
MikeDombo
reviewed
May 10, 2024
MikeDombo
reviewed
May 10, 2024
src/main/java/com/aws/greengrass/deployment/ConnectivityValidator.java
Outdated
Show resolved
Hide resolved
tiancishen
force-pushed
the
resilientNucleusConfig
branch
from
May 10, 2024 18:59
f32b2d5
to
7201e9f
Compare
alter-mage
reviewed
May 10, 2024
alter-mage
reviewed
May 10, 2024
src/main/java/com/aws/greengrass/deployment/ConnectivityValidator.java
Outdated
Show resolved
Hide resolved
alter-mage
reviewed
May 10, 2024
src/test/java/com/aws/greengrass/tes/TokenExchangeServiceTest.java
Outdated
Show resolved
Hide resolved
alter-mage
reviewed
May 10, 2024
src/test/java/com/aws/greengrass/mqttclient/MqttClientTest.java
Outdated
Show resolved
Hide resolved
tiancishen
force-pushed
the
resilientNucleusConfig
branch
from
May 14, 2024 17:46
7201e9f
to
aacbfdf
Compare
alter-mage
previously approved these changes
May 14, 2024
junfuchen99
reviewed
May 15, 2024
src/main/java/com/aws/greengrass/deployment/ConnectivityValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/aws/greengrass/deployment/DeploymentConfigMerger.java
Outdated
Show resolved
Hide resolved
...ontests/java/com/aws/greengrass/integrationtests/deployment/DeploymentConfigMergingTest.java
Show resolved
Hide resolved
tiancishen
force-pushed
the
resilientNucleusConfig
branch
from
May 16, 2024 00:26
aacbfdf
to
875fa60
Compare
junfuchen99
reviewed
May 16, 2024
src/main/java/com/aws/greengrass/deployment/ConnectivityValidator.java
Outdated
Show resolved
Hide resolved
tiancishen
force-pushed
the
resilientNucleusConfig
branch
from
May 17, 2024 00:49
875fa60
to
c63d7af
Compare
tiancishen
force-pushed
the
resilientNucleusConfig
branch
from
May 17, 2024 01:17
c63d7af
to
0c21629
Compare
junfuchen99
approved these changes
May 17, 2024
alter-mage
approved these changes
May 18, 2024
junfuchen99
added
the
work-in-progress
PR is actively being worked on and should not be considered ready for review
label
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
work-in-progress
PR is actively being worked on and should not be considered ready for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
validateConnectivityDuringDeployment
Nucleus config is set to false, or the device is configured to be offlineExample of errors that can be seen on the console:
MQTT validation failures
HTTP validation failure
Why is this change necessary:
Nucleus doesn't validate mqtt and http connections when merging in a new configuration from deployment. Prevent Nucleus from accepting a bad configuration deployment by validating connectivity with the deploymeny Nucleus configuration
How was this change tested:
Test using UATs covers the following scenarios:
Any additional information or context required to review the change:
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.