chore: refactor component update event handlers #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeDombo
reviewed
Sep 22, 2023
| @Getter(AccessLevel.PACKAGE) | ||
| private final ConcurrentHashMap<String, Set<StreamEventPublisher<ComponentUpdatePolicyEvents>>> | ||
| componentUpdateListeners = new ConcurrentHashMap<>(); | ||
|
|
||
| // Listeners registered from plugins | ||
| private final ConcurrentHashMap<String, Set<Consumer<ComponentUpdatePolicyEvents>>> |
There was a problem hiding this comment.
you can use DefaultConcurrentHashMap
shaguptashaikh
force-pushed
the
update-event-refactor
branch
from
b83f710 to
04d6557
Compare
alter-mage
previously approved these changes
Sep 22, 2023
shaguptashaikh
force-pushed
the
update-event-refactor
branch
from
04d6557 to
003c649
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/com/aws/greengrass/builtin/services/lifecycle/LifecycleIPCEventStreamAgent.java
Fixed
Show fixed
Hide fixed
shaguptashaikh
force-pushed
the
update-event-refactor
branch
from
003c649 to
78f1b8c
Compare
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 0623a9c |
|
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 0623a9c |
alter-mage
approved these changes
Sep 29, 2023
junfuchen99
previously approved these changes
Sep 29, 2023
alter-mage
requested changes
Sep 29, 2023
| * @throws InvalidArgumentsError if service name or deployment id inputs are invalid | ||
| */ | ||
| public void deferComponentUpdate(DeferComponentUpdateRequest request, String serviceName) { | ||
| if (!componentUpdateListeners.containsKey(serviceName)) { |
There was a problem hiding this comment.
This should be componentUpdateListenersInternal, right?
There was a problem hiding this comment.
I need to check both maps, will update
shaguptashaikh
force-pushed
the
update-event-refactor
branch
from
a837d7c to
be480ae
Compare
alter-mage
approved these changes
Sep 29, 2023
junfuchen99
approved these changes
Sep 29, 2023
|
Binary incompatibility detected for commit 0623a9c. com.aws.greengrass.componentmanager.builtins.ArtifactDownloaderFactory is binary incompatible and is source incompatible because of CONSTRUCTOR_REMOVED Produced by binaryCompatability.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Why is this change necessary:
To allow plugins to subscribe to update events and defer update without needing to use an IPC client
How was this change tested:
Any additional information or context required to review the change:
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.