feat(s3Endpoint): enable configurable s3 endpoint as global or regional #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junfuchen99
reviewed
Sep 20, 2023
| @@ -38,7 +38,7 @@ | |||
| <dependency> | |||
| <groupId>software.amazon.awssdk</groupId> | |||
| <artifactId>bom</artifactId> | |||
| <version>2.17.295</version> | |||
| <version>2.20.138</version> | |||
There was a problem hiding this comment.
is this sdk version change necessary?
There was a problem hiding this comment.
Yes, 2.17.295 is not compatible with new greengrassv2-data
There was a problem hiding this comment.
We need to be careful with this bump and check if it breaks compatibility with any other functionalities
src/main/java/com/aws/greengrass/deployment/DeviceConfiguration.java
Outdated
Show resolved
Hide resolved
yitingb
force-pushed
the
main_testUnit
branch
from
8463a21 to
b4633d5
Compare
junfuchen99
reviewed
Sep 25, 2023
| @@ -38,7 +38,7 @@ | |||
| <dependency> | |||
| <groupId>software.amazon.awssdk</groupId> | |||
| <artifactId>bom</artifactId> | |||
| <version>2.17.295</version> | |||
| <version>2.20.138</version> | |||
There was a problem hiding this comment.
We need to be careful with this bump and check if it breaks compatibility with any other functionalities
src/main/java/com/aws/greengrass/deployment/DeviceConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/aws/greengrass/deployment/DeviceConfiguration.java
Outdated
Show resolved
Hide resolved
yitingb
force-pushed
the
main_testUnit
branch
from
b4633d5 to
34d4073
Compare
junfuchen99
reviewed
Sep 26, 2023
src/main/java/com/aws/greengrass/deployment/DeviceConfiguration.java
Outdated
Show resolved
Hide resolved
yitingb
force-pushed
the
main_testUnit
branch
2 times, most recently
from
c0dc6ab to
669cf25
Compare
yitingb
changed the title
yitingb
force-pushed
the
main_testUnit
branch
from
669cf25 to
3c73c79
Compare
junfuchen99
reviewed
Sep 28, 2023
src/main/java/com/aws/greengrass/deployment/model/S3EndpointType.java
Outdated
Show resolved
Hide resolved
src/main/java/com/aws/greengrass/deployment/DeviceConfiguration.java
Outdated
Show resolved
Hide resolved
src/test/java/com/aws/greengrass/util/S3SdkClientFactoryTest.java
Outdated
Show resolved
Hide resolved
yitingb
force-pushed
the
main_testUnit
branch
from
3c73c79 to
9671c7c
Compare
MikeDombo
reviewed
Sep 28, 2023
| if (isGlobal && S3_REGIONAL_ENDPOINT_VALUE.equals(s3EndpointSystemProp)) { | ||
| System.clearProperty(S3_ENDPOINT_PROP_NAME); | ||
| refreshClientCache(); | ||
| logger.atInfo().log("s3 endpoint set to global"); |
There was a problem hiding this comment.
do not log this at info, this is going to happen a lot
MikeDombo
reviewed
Sep 28, 2023
MikeDombo
reviewed
Sep 28, 2023
| import software.amazon.awssdk.services.greengrassv2data.model.GetDeploymentConfigurationResponse; | ||
| import software.amazon.awssdk.services.greengrassv2data.model.GreengrassV2DataException; | ||
| import software.amazon.awssdk.services.greengrassv2data.model.IntegrityCheck; | ||
| import software.amazon.awssdk.services.greengrassv2data.model.*; |
yitingb
force-pushed
the
main_testUnit
branch
from
9671c7c to
a14eb38
Compare
junfuchen99
reviewed
Sep 29, 2023
junfuchen99
previously approved these changes
Sep 29, 2023
yitingb
force-pushed
the
main_testUnit
branch
from
2e76255 to
fd26c49
Compare
junfuchen99
approved these changes
Sep 29, 2023
alter-mage
approved these changes
Sep 29, 2023
|
Binary incompatibility detected for commit bedf949. com.aws.greengrass.componentmanager.builtins.ArtifactDownloaderFactory is binary incompatible and is source incompatible because of CONSTRUCTOR_REMOVED Produced by binaryCompatability.py |
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against bedf949 |
|
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against bedf949 |
junfuchen99
pushed a commit
that referenced
this pull request
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Enable s3 endpoint to be configurable, users could merge the s3 endpoint type from configuration to use"REGIONAL" or "GLOBAL".
Why is this change necessary:
This change unblocks VPC users who can only use regional endpoints.
How was this change tested:
Any additional information or context required to review the change:
Documentation Checklist:
Compatibility Checklist:
any deprecated method or type.
Refer to Compatibility Guidelines for more information.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.