fix(deployment): propagate interrupt from list groups operation (#1554)

aws-greengrass · Jul 17, 2024 · f225de5 · f225de5
1 parent 6bd81f5
commit f225de5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/main/java/com/aws/greengrass/deployment/DefaultDeploymentTask.java b/src/main/java/com/aws/greengrass/deployment/DefaultDeploymentTask.java
@@ -181,7 +181,7 @@ public DeploymentResult call() throws InterruptedException {
         }
     }
 
-    @SuppressWarnings({"PMD.AvoidCatchingGenericException"})
+    @SuppressWarnings({"PMD.AvoidCatchingGenericException", "PMD.AvoidRethrowingException"})
     private Map<String, Set<ComponentRequirementIdentifier>> getNonTargetGroupToRootPackagesMap(
             DeploymentDocument deploymentDocument)
             throws DeploymentTaskFailureException, InterruptedException {
@@ -208,6 +208,8 @@ private Map<String, Set<ComponentRequirementIdentifier>> getNonTargetGroupToRoot
             } else {
                 throw new DeploymentTaskFailureException("Error fetching thing group information", e);
             }
+        } catch (InterruptedException e) {
+            throw e;
         } catch (Exception e) {
             if (isLocalDeployment && ThingGroupHelper.RETRYABLE_EXCEPTIONS.contains(e.getClass())) {
                 logger.atWarn().setCause(e).log("Failed to get thing group hierarchy, local deployment will proceed");

diff --git a/src/test/java/com/aws/greengrass/deployment/DeploymentTaskTest.java b/src/test/java/com/aws/greengrass/deployment/DeploymentTaskTest.java
@@ -170,6 +170,12 @@ void GIVEN_deploymentDocument_WHEN_thingGroupHelper_throws_error_THEN_deployment
         assertEquals("Error fetching thing group information. Original error message", failureMessage);
     }
 
+    @Test
+    void GIVEN_deploymentDocument_WHEN_thingGroupHelper_interrupted_THEN_deployment_task_interrupted() throws Exception {
+        when(mockThingGroupHelper.listThingGroupsForDevice(anyInt())).thenThrow(InterruptedException.class);
+        assertThrows(InterruptedException.class, deploymentTask::call);
+    }
+
     @Test
     void GIVEN_deploymentDocument_WHEN_resolveDependencies_errored_THEN_deploymentTask_aborted(ExtensionContext context)
             throws Exception {